Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: webrtc/api/statscollector.cc

Issue 1802013002: A bunch of interfaces: Return scoped_ptr<SSLCertificate> (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/api/statscollector_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/statscollector.cc
diff --git a/webrtc/api/statscollector.cc b/webrtc/api/statscollector.cc
index d77953b3bed1d49bb75a3be6a35c5d10f91c382b..ec176ef77ee581b73c79f85b7ba4b387ef649262 100644
--- a/webrtc/api/statscollector.cc
+++ b/webrtc/api/statscollector.cc
@@ -703,9 +703,9 @@ void StatsCollector::ExtractSessionInfo() {
local_cert_report_id = r->id();
}
- rtc::scoped_ptr<rtc::SSLCertificate> cert;
- if (pc_->session()->GetRemoteSSLCertificate(
- transport_iter.second.transport_name, cert.accept())) {
+ auto cert = pc_->session()->GetRemoteSSLCertificate(
torbjorng (webrtc) 2016/03/23 14:18:23 I think this use of auto makes the code less reada
kwiberg-webrtc 2016/03/23 15:05:27 Done. Also in a few other places; the only remaini
+ transport_iter.second.transport_name);
+ if (cert) {
StatsReport* r = AddCertificateReports(cert.get());
if (r)
remote_cert_report_id = r->id();
« no previous file with comments | « no previous file | webrtc/api/statscollector_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698