webrtc/p2p/base/transportcontroller.h - Issue 1802013002: A bunch of interfaces: Return scoped_ptr<SSLCertificate>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/p2p/base/transportcontroller.h

Issue 1802013002: A bunch of interfaces: Return scoped_ptr<SSLCertificate> (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: less auto Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/p2p/base/transportcontroller.h

diff --git a/webrtc/p2p/base/transportcontroller.h b/webrtc/p2p/base/transportcontroller.h

index ed7216033b429d91625fd16a3c86d3a55cf9722f..9d06823920f668d32796eba90e44394c15f16ebe 100644

--- a/webrtc/p2p/base/transportcontroller.h

+++ b/webrtc/p2p/base/transportcontroller.h

@@ -59,8 +59,8 @@ class TransportController : public sigslot::has_slots<>,

const std::string& transport_name,

rtc::scoped_refptr<rtc::RTCCertificate>* certificate);

// Caller owns returned certificate

- bool GetRemoteSSLCertificate(const std::string& transport_name,

- rtc::SSLCertificate** cert);

+ rtc::scoped_ptr<rtc::SSLCertificate> GetRemoteSSLCertificate(

+ const std::string& transport_name);

bool SetLocalTransportDescription(const std::string& transport_name,

const TransportDescription& tdesc,

ContentAction action,

@@ -166,8 +166,8 @@ class TransportController : public sigslot::has_slots<>,

bool GetLocalCertificate_w(

const std::string& transport_name,

rtc::scoped_refptr<rtc::RTCCertificate>* certificate);

- bool GetRemoteSSLCertificate_w(const std::string& transport_name,

- rtc::SSLCertificate** cert);

+ rtc::scoped_ptr<rtc::SSLCertificate> GetRemoteSSLCertificate_w(

+ const std::string& transport_name);

bool SetLocalTransportDescription_w(const std::string& transport_name,

const TransportDescription& tdesc,

ContentAction action,

« no previous file with comments | « webrtc/p2p/base/transportchannel.h ('k') | webrtc/p2p/base/transportcontroller.cc » ('j') | no next file with comments »