talk/build/OWNERS - Issue 1801943003: Move build scripts to webrtc/build/ios

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: talk/build/OWNERS

Issue 1801943003: Move build scripts to webrtc/build/ios (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Fix some presubmit errors and remove talk/build Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
	(Empty)
1

2 # These are for the common case of adding or renaming files. If you're doing

3 # structural changes, please get a review from a reviewer in this file.
tkchin_webrtc 2016/03/14 23:22:10 Wouldn't delete this file just yet. Maybe add kjel Wouldn't delete this file just yet. Maybe add kjellander@webrtc.org explicitly here :) So he can approve these deletions. kjellander_webrtc 2016/03/15 04:03:09 I don't think you can add me and have me lgtm in t Show quoted text On 2016/03/14 23:22:10, tkchin_webrtc wrote: > Wouldn't delete this file just yet. > Maybe add mailto:kjellander@webrtc.org explicitly here :) So he can approve these > deletions. I don't think you can add me and have me lgtm in the same CL :) Just add a talk/ OWNER for this CL. hjon_webrtc 2016/03/15 21:07:48 Acknowledged. Show quoted text On 2016/03/15 04:03:09, kjellander (webrtc) wrote: > On 2016/03/14 23:22:10, tkchin_webrtc wrote: > > Wouldn't delete this file just yet. > > Maybe add mailto:kjellander@webrtc.org explicitly here :) So he can approve > these > > deletions. > > I don't think you can add me and have me lgtm in the same CL :) > Just add a talk/ OWNER for this CL. Acknowledged. hjon_webrtc 2016/03/15 21:07:48 Done. Hoping you meant add kjellander@webrtc.org t Show quoted text On 2016/03/14 23:22:10, tkchin_webrtc wrote: > Wouldn't delete this file just yet. > Maybe add mailto:kjellander@webrtc.org explicitly here :) So he can approve these > deletions. Done. Hoping you meant add kjellander@webrtc.org to this file since that's what I decided to do. I did also add him as a reviewer.
4 per-file .gyp=

5 per-file .gypi=

OLD	NEW

« no previous file with comments | « no previous file | talk/build/build_ios_libs.sh » ('j') | webrtc/build/ios/merge_ios_libs » ('J')