Move build scripts to webrtc/build/ios

Move build scripts to webrtc/build/ios

BUG=
NOTRY=True

Committed: https://crrev.com/bc73fe1aadb87b2fe6f844cc14df2f1b52f0e22e
Cr-Commit-Position: refs/heads/master@{#12079}

[hjon_webrtc, 2016-03-14 23:06:23]

Description was changed from

==========
Add build scripts to webrtc/build/ios

BUG=
==========

to

==========
Move build scripts to webrtc/build/ios

BUG=
==========

[hjon_webrtc, 2016-03-14 23:08:04]

hjon@webrtc.org changed reviewers:
+ kjellander@webrtc.org, tkchin@webrtc.org

[hjon_webrtc, 2016-03-14 23:08:04]

I received this error on upload; not sure if it's something I should be
resolving and if so, how to do so.

** Presubmit ERRORS **
mb_validate (0.05s) failed
mb config file /Users/hjon/WebRTC/src/webrtc/build/mb_config.pyl has problems:
  Missing "chromium" master. Please update this proprietary codecs check with
the name of the master responsible for public build artifacts.

[tkchin_webrtc, 2016-03-14 23:22:10]

https://codereview.webrtc.org/1801943003/diff/20001/talk/build/OWNERS
File talk/build/OWNERS (left):

https://codereview.webrtc.org/1801943003/diff/20001/talk/build/OWNERS#oldcode3
talk/build/OWNERS:3: # structural changes, please get a review from a reviewer
in this file.
Wouldn't delete this file just yet.
Maybe add kjellander@webrtc.org explicitly here :) So he can approve these
deletions.

https://codereview.webrtc.org/1801943003/diff/20001/webrtc/build/ios/merge_io...
File webrtc/build/ios/merge_ios_libs (right):

https://codereview.webrtc.org/1801943003/diff/20001/webrtc/build/ios/merge_io...
webrtc/build/ios/merge_ios_libs:3: # libjingle
update license

https://codereview.webrtc.org/1801943003/diff/20001/webrtc/build/ios/merge_io...
File webrtc/build/ios/merge_ios_libs.gyp (right):

https://codereview.webrtc.org/1801943003/diff/20001/webrtc/build/ios/merge_io...
webrtc/build/ios/merge_ios_libs.gyp:5: # Redistribution and use in source and
binary forms, with or without
ditto license

https://codereview.webrtc.org/1801943003/diff/20001/webrtc/build/ios/objc_app...
File webrtc/build/ios/objc_app.gypi (left):

https://codereview.webrtc.org/1801943003/diff/20001/webrtc/build/ios/objc_app...
webrtc/build/ios/objc_app.gypi:32: 'variables': {
Can you see where objc_app.gypi is used? I would think that moving it would
break targets.

https://codereview.webrtc.org/1801943003/diff/20001/webrtc/build/ios/objc_app...
File webrtc/build/ios/objc_app.gypi (right):

https://codereview.webrtc.org/1801943003/diff/20001/webrtc/build/ios/objc_app...
webrtc/build/ios/objc_app.gypi:5: # Redistribution and use in source and binary
forms, with or without
ditto license

[kjellander_webrtc, 2016-03-15 03:55:42]

On 2016/03/14 23:08:04, hjon_webrtc wrote:
> I received this error on upload; not sure if it's something I should be
> resolving and if so, how to do so.
> 
> ** Presubmit ERRORS **
> mb_validate (0.05s) failed
> mb config file /Users/hjon/WebRTC/src/webrtc/build/mb_config.pyl has problems:
>   Missing "chromium" master. Please update this proprietary codecs check with
> the name of the master responsible for public build artifacts.

Please ignore that error (use --bypass-hooks). I posted a comment in
https://codereview.chromium.org/1773883002/ asking for Chromium to fix it.

[kjellander_webrtc, 2016-03-15 04:03:10]

Nice initiative. Just needs a bit more testing, then we can get rid of
talk/build!

https://codereview.webrtc.org/1801943003/diff/20001/talk/build/OWNERS
File talk/build/OWNERS (left):

https://codereview.webrtc.org/1801943003/diff/20001/talk/build/OWNERS#oldcode3
talk/build/OWNERS:3: # structural changes, please get a review from a reviewer
in this file.
On 2016/03/14 23:22:10, tkchin_webrtc wrote:
> Wouldn't delete this file just yet.
> Maybe add mailto:kjellander@webrtc.org explicitly here :) So he can approve
these
> deletions.

I don't think you can add me and have me lgtm in the same CL :)
Just add a talk/ OWNER for this CL.

https://codereview.webrtc.org/1801943003/diff/20001/webrtc/build/ios/merge_io...
File webrtc/build/ios/merge_ios_libs.gyp (right):

https://codereview.webrtc.org/1801943003/diff/20001/webrtc/build/ios/merge_io...
webrtc/build/ios/merge_ios_libs.gyp:28: 'includes':
['<(webrtc_root)/build/common.gypi',],
Don't use a variable here (I didn't even expect that to work).

https://codereview.webrtc.org/1801943003/diff/20001/webrtc/build/ios/merge_io...
webrtc/build/ios/merge_ios_libs.gyp:37:
'../app/webrtc/legacy_objc_api.gyp:libjingle_peerconnection_objc',
This won't work. Please test generating project files with this .gyp file in its
new location.

https://codereview.webrtc.org/1801943003/diff/20001/webrtc/build/ios/objc_app...
File webrtc/build/ios/objc_app.gypi (left):

https://codereview.webrtc.org/1801943003/diff/20001/webrtc/build/ios/objc_app...
webrtc/build/ios/objc_app.gypi:32: 'variables': {
On 2016/03/14 23:22:10, tkchin_webrtc wrote:
> Can you see where objc_app.gypi is used? I would think that moving it would
> break targets.

Yepp it should break things unless updated:

$ git gs objc_app.gypi
talk/app/webrtc/legacy_objc_api_tests.gyp:38:          'includes': [
'../../build/objc_app.gypi' ],
talk/app/webrtc/legacy_objc_api_tests.gyp:70:          'includes': [
'../../build/objc_app.gypi' ],
talk/build/merge_ios_libs.gyp:34:          'includes': [ 'objc_app.gypi' ],
talk/build/merge_ios_libs.gyp:43:          'includes': [ 'objc_app.gypi' ],

[kjellander_webrtc, 2016-03-15 05:16:43]

On 2016/03/15 04:03:10, kjellander (webrtc) wrote:
> Nice initiative. Just needs a bit more testing, then we can get rid of
> talk/build!
> 
> https://codereview.webrtc.org/1801943003/diff/20001/talk/build/OWNERS
> File talk/build/OWNERS (left):
> 
> https://codereview.webrtc.org/1801943003/diff/20001/talk/build/OWNERS#oldcode3
> talk/build/OWNERS:3: # structural changes, please get a review from a reviewer
> in this file.
> On 2016/03/14 23:22:10, tkchin_webrtc wrote:
> > Wouldn't delete this file just yet.
> > Maybe add mailto:kjellander@webrtc.org explicitly here :) So he can approve
> these
> > deletions.
> 
> I don't think you can add me and have me lgtm in the same CL :)
> Just add a talk/ OWNER for this CL.

oops, this does not lgtm yet :)

> 
>
https://codereview.webrtc.org/1801943003/diff/20001/webrtc/build/ios/merge_io...
> File webrtc/build/ios/merge_ios_libs.gyp (right):
> 
>
https://codereview.webrtc.org/1801943003/diff/20001/webrtc/build/ios/merge_io...
> webrtc/build/ios/merge_ios_libs.gyp:28: 'includes':
> ['<(webrtc_root)/build/common.gypi',],
> Don't use a variable here (I didn't even expect that to work).
> 
>
https://codereview.webrtc.org/1801943003/diff/20001/webrtc/build/ios/merge_io...
> webrtc/build/ios/merge_ios_libs.gyp:37:
> '../app/webrtc/legacy_objc_api.gyp:libjingle_peerconnection_objc',
> This won't work. Please test generating project files with this .gyp file in
its
> new location.
> 
>
https://codereview.webrtc.org/1801943003/diff/20001/webrtc/build/ios/objc_app...
> File webrtc/build/ios/objc_app.gypi (left):
> 
>
https://codereview.webrtc.org/1801943003/diff/20001/webrtc/build/ios/objc_app...
> webrtc/build/ios/objc_app.gypi:32: 'variables': {
> On 2016/03/14 23:22:10, tkchin_webrtc wrote:
> > Can you see where objc_app.gypi is used? I would think that moving it would
> > break targets.
> 
> Yepp it should break things unless updated:
> 
> $ git gs objc_app.gypi
> talk/app/webrtc/legacy_objc_api_tests.gyp:38:          'includes': [
> '../../build/objc_app.gypi' ],
> talk/app/webrtc/legacy_objc_api_tests.gyp:70:          'includes': [
> '../../build/objc_app.gypi' ],
> talk/build/merge_ios_libs.gyp:34:          'includes': [ 'objc_app.gypi' ],
> talk/build/merge_ios_libs.gyp:43:          'includes': [ 'objc_app.gypi' ],

[hjon_webrtc, 2016-03-15 21:07:49]

https://codereview.webrtc.org/1801943003/diff/20001/talk/build/OWNERS
File talk/build/OWNERS (left):

https://codereview.webrtc.org/1801943003/diff/20001/talk/build/OWNERS#oldcode3
talk/build/OWNERS:3: # structural changes, please get a review from a reviewer
in this file.
On 2016/03/14 23:22:10, tkchin_webrtc wrote:
> Wouldn't delete this file just yet.
> Maybe add mailto:kjellander@webrtc.org explicitly here :) So he can approve
these
> deletions.

Done. Hoping you meant add kjellander@webrtc.org to this file since that's what
I decided to do. I did also add him as a reviewer.

https://codereview.webrtc.org/1801943003/diff/20001/talk/build/OWNERS#oldcode3
talk/build/OWNERS:3: # structural changes, please get a review from a reviewer
in this file.
On 2016/03/15 04:03:09, kjellander (webrtc) wrote:
> On 2016/03/14 23:22:10, tkchin_webrtc wrote:
> > Wouldn't delete this file just yet.
> > Maybe add mailto:kjellander@webrtc.org explicitly here :) So he can approve
> these
> > deletions.
> 
> I don't think you can add me and have me lgtm in the same CL :)
> Just add a talk/ OWNER for this CL.

Acknowledged.

https://codereview.webrtc.org/1801943003/diff/20001/webrtc/build/ios/merge_io...
File webrtc/build/ios/merge_ios_libs (right):

https://codereview.webrtc.org/1801943003/diff/20001/webrtc/build/ios/merge_io...
webrtc/build/ios/merge_ios_libs:3: # libjingle
On 2016/03/14 23:22:10, tkchin_webrtc wrote:
> update license

Done.

https://codereview.webrtc.org/1801943003/diff/20001/webrtc/build/ios/merge_io...
File webrtc/build/ios/merge_ios_libs.gyp (right):

https://codereview.webrtc.org/1801943003/diff/20001/webrtc/build/ios/merge_io...
webrtc/build/ios/merge_ios_libs.gyp:5: # Redistribution and use in source and
binary forms, with or without
On 2016/03/14 23:22:10, tkchin_webrtc wrote:
> ditto license

Done.

https://codereview.webrtc.org/1801943003/diff/20001/webrtc/build/ios/merge_io...
webrtc/build/ios/merge_ios_libs.gyp:28: 'includes':
['<(webrtc_root)/build/common.gypi',],
On 2016/03/15 04:03:09, kjellander (webrtc) wrote:
> Don't use a variable here (I didn't even expect that to work).

Done.

https://codereview.webrtc.org/1801943003/diff/20001/webrtc/build/ios/merge_io...
webrtc/build/ios/merge_ios_libs.gyp:37:
'../app/webrtc/legacy_objc_api.gyp:libjingle_peerconnection_objc',
On 2016/03/15 04:03:09, kjellander (webrtc) wrote:
> This won't work. Please test generating project files with this .gyp file in
its
> new location.

Done.

https://codereview.webrtc.org/1801943003/diff/20001/webrtc/build/ios/objc_app...
File webrtc/build/ios/objc_app.gypi (left):

https://codereview.webrtc.org/1801943003/diff/20001/webrtc/build/ios/objc_app...
webrtc/build/ios/objc_app.gypi:32: 'variables': {
On 2016/03/15 04:03:10, kjellander (webrtc) wrote:
> On 2016/03/14 23:22:10, tkchin_webrtc wrote:
> > Can you see where objc_app.gypi is used? I would think that moving it would
> > break targets.
> 
> Yepp it should break things unless updated:
> 
> $ git gs objc_app.gypi
> talk/app/webrtc/legacy_objc_api_tests.gyp:38:          'includes': [
> '../../build/objc_app.gypi' ],
> talk/app/webrtc/legacy_objc_api_tests.gyp:70:          'includes': [
> '../../build/objc_app.gypi' ],
> talk/build/merge_ios_libs.gyp:34:          'includes': [ 'objc_app.gypi' ],
> talk/build/merge_ios_libs.gyp:43:          'includes': [ 'objc_app.gypi' ],

Done.

https://codereview.webrtc.org/1801943003/diff/20001/webrtc/build/ios/objc_app...
File webrtc/build/ios/objc_app.gypi (right):

https://codereview.webrtc.org/1801943003/diff/20001/webrtc/build/ios/objc_app...
webrtc/build/ios/objc_app.gypi:5: # Redistribution and use in source and binary
forms, with or without
On 2016/03/14 23:22:10, tkchin_webrtc wrote:
> ditto license

Done.

https://codereview.webrtc.org/1801943003/diff/60001/talk/app/webrtc/legacy_ob...
File talk/app/webrtc/legacy_objc_api_tests.gyp (right):

https://codereview.webrtc.org/1801943003/diff/60001/talk/app/webrtc/legacy_ob...
talk/app/webrtc/legacy_objc_api_tests.gyp:28: 'includes':
['../../build/common.gypi'],
In legacy_objc_api.gyp, webrtc_examples.gyp, and here, I tried to use
webrtc/build/common.gypi, but in each case, that change resulted in compiler
errors that I believe are out of scope for this CL (unused variable warnings as
an example). My intent is to file an issue for transitioning those gyp files to
webrtc/build/common.gypi.

[hjon_webrtc, 2016-03-15 21:08:51]

hjon@webrtc.org changed reviewers:
+ jiayl@webrtc.org

[hjon_webrtc, 2016-03-15 21:08:51]

@jiayl Could you also take a look?

[jiayl2, 2016-03-15 21:43:29]

I'll rubber stamp after Zeke's lgtm

[kjellander_webrtc, 2016-03-16 00:52:44]

lgtm assuming the trybots I triggered are passing (I think you should be able to
safely land manually or with NOTRY=True) if that's the case.

https://codereview.webrtc.org/1801943003/diff/60001/talk/app/webrtc/legacy_ob...
File talk/app/webrtc/legacy_objc_api_tests.gyp (right):

https://codereview.webrtc.org/1801943003/diff/60001/talk/app/webrtc/legacy_ob...
talk/app/webrtc/legacy_objc_api_tests.gyp:28: 'includes':
['../../build/common.gypi'],
On 2016/03/15 21:07:48, hjon_webrtc wrote:
> In legacy_objc_api.gyp, webrtc_examples.gyp, and here, I tried to use
> webrtc/build/common.gypi, but in each case, that change resulted in compiler
> errors that I believe are out of scope for this CL (unused variable warnings
as
> an example). My intent is to file an issue for transitioning those gyp files
to
> webrtc/build/common.gypi.

Yeah, the warning level is different: something I painfully experienced when
moving other talk/ stuff to webrtc/. You may want to look at my CLs for that for
quick examples on how to disable just the warnings that are needed (so you don't
have to fix all of them).

[tkchin_webrtc, 2016-03-16 18:04:26]

On 2016/03/16 00:52:44, kjellander (webrtc) wrote:
> lgtm assuming the trybots I triggered are passing (I think you should be able
to
> safely land manually or with NOTRY=True) if that's the case.
> 
>
https://codereview.webrtc.org/1801943003/diff/60001/talk/app/webrtc/legacy_ob...
> File talk/app/webrtc/legacy_objc_api_tests.gyp (right):
> 
>
https://codereview.webrtc.org/1801943003/diff/60001/talk/app/webrtc/legacy_ob...
> talk/app/webrtc/legacy_objc_api_tests.gyp:28: 'includes':
> ['../../build/common.gypi'],
> On 2016/03/15 21:07:48, hjon_webrtc wrote:
> > In legacy_objc_api.gyp, webrtc_examples.gyp, and here, I tried to use
> > webrtc/build/common.gypi, but in each case, that change resulted in compiler
> > errors that I believe are out of scope for this CL (unused variable warnings
> as
> > an example). My intent is to file an issue for transitioning those gyp files
> to
> > webrtc/build/common.gypi.
> 
> Yeah, the warning level is different: something I painfully experienced when
> moving other talk/ stuff to webrtc/. You may want to look at my CLs for that
for
> quick examples on how to disable just the warnings that are needed (so you
don't
> have to fix all of them).

lgtm

[jiayl2, 2016-03-16 18:05:31]

lgtm

[hjon_webrtc, 2016-03-21 18:36:33]

Description was changed from

==========
Move build scripts to webrtc/build/ios

BUG=
==========

to

==========
Move build scripts to webrtc/build/ios

BUG=
NOTRY=True
==========

[hjon_webrtc, 2016-03-21 18:36:40]

The CQ bit was checked by hjon@webrtc.org

[commit-bot: I haz the power, 2016-03-21 18:36:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1801943003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1801943003/60001

[commit-bot: I haz the power, 2016-03-21 18:38:30]

Description was changed from

==========
Move build scripts to webrtc/build/ios

BUG=
NOTRY=True
==========

to

==========
Move build scripts to webrtc/build/ios

BUG=
NOTRY=True
==========

[commit-bot: I haz the power, 2016-03-21 18:38:31]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-21 18:38:40]

Description was changed from

==========
Move build scripts to webrtc/build/ios

BUG=
NOTRY=True
==========

to

==========
Move build scripts to webrtc/build/ios

BUG=
NOTRY=True

Committed: https://crrev.com/bc73fe1aadb87b2fe6f844cc14df2f1b52f0e22e
Cr-Commit-Position: refs/heads/master@{#12079}
==========

[commit-bot: I haz the power, 2016-03-21 18:38:41]

Patchset 4 (id:??) landed as
https://crrev.com/bc73fe1aadb87b2fe6f844cc14df2f1b52f0e22e
Cr-Commit-Position: refs/heads/master@{#12079}