Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1801003002: Removed the dependency on AudioProcessingImpl in GainControlImpl (Closed)

Created:
4 years, 9 months ago by peah-webrtc
Modified:
4 years, 9 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removed the dependency on AudioProcessingImpl in GainControlImpl BUG=webrtc:5353 Committed: https://crrev.com/b8fbb542910f5dbe188af5ab16b65b765dea298e Cr-Commit-Position: refs/heads/master@{#11994}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -40 lines) Patch
M webrtc/modules/audio_processing/audio_processing_impl.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/gain_control_impl.h View 3 chunks +6 lines, -9 lines 0 comments Download
M webrtc/modules/audio_processing/gain_control_impl.cc View 15 chunks +37 lines, -28 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
peah-webrtc
4 years, 9 months ago (2016-03-15 06:10:39 UTC) #2
hlundin-webrtc
lgtm
4 years, 9 months ago (2016-03-15 07:38:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1801003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1801003002/1
4 years, 9 months ago (2016-03-15 07:39:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_x64_clang_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_clang_dbg/builds/1830)
4 years, 9 months ago (2016-03-15 07:54:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1801003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1801003002/1
4 years, 9 months ago (2016-03-15 08:04:40 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-15 09:28:13 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 09:28:20 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b8fbb542910f5dbe188af5ab16b65b765dea298e
Cr-Commit-Position: refs/heads/master@{#11994}

Powered by Google App Engine
This is Rietveld 408576698