Port::GetStunMessage: Write to scoped_ptr instead of raw pointer

Port::GetStunMessage: Write to scoped_ptr instead of raw pointer

This is a good idea in general, because it makes ownership clearer,
but will also be very convenient when scoped_ptr is gone, since
unique_ptr doesn't have an .accept() method.

BUG=webrtc:5520
Committed: https://crrev.com/6baec0351aab267fb4f07b95778ae2e5f0d58f05
Cr-Commit-Position: refs/heads/master@{#12002}

[kwiberg-webrtc, 2016-03-15 09:25:17]

kwiberg@webrtc.org changed reviewers:
+ tommi@webrtc.org

[tommi, 2016-03-15 09:30:16]

https://codereview.webrtc.org/1800753003/diff/1/webrtc/p2p/base/port.cc
File webrtc/p2p/base/port.cc (right):

https://codereview.webrtc.org/1800753003/diff/1/webrtc/p2p/base/port.cc#newco...
webrtc/p2p/base/port.cc:343: out_msg->reset();
Prefer to have this be the caller's responsibility. You could have a dcheck here
if you want.

[kwiberg-webrtc, 2016-03-15 10:16:01]

https://codereview.webrtc.org/1800753003/diff/1/webrtc/p2p/base/port.cc
File webrtc/p2p/base/port.cc (right):

https://codereview.webrtc.org/1800753003/diff/1/webrtc/p2p/base/port.cc#newco...
webrtc/p2p/base/port.cc:343: out_msg->reset();
On 2016/03/15 09:30:16, tommi-webrtc wrote:
> Prefer to have this be the caller's responsibility. You could have a dcheck
here
> if you want. 

Sure. I just left it in because I wanted to make a minimal change.

Removed. No caller depended on this behavior.

[tommi, 2016-03-15 17:02:40]

The CQ bit was checked by tommi@webrtc.org

[tommi, 2016-03-15 17:02:40]

lgtm

[commit-bot: I haz the power, 2016-03-15 17:02:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1800753003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1800753003/20001

[commit-bot: I haz the power, 2016-03-15 18:09:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-15 18:10:02]

Description was changed from

==========
Port::GetStunMessage: Write to scoped_ptr instead of raw pointer

This is a good idea in general, because it makes ownership clearer,
but will also be very convenient when scoped_ptr is gone, since
unique_ptr doesn't have an .accept() method.

BUG=webrtc:5520
==========

to

==========
Port::GetStunMessage: Write to scoped_ptr instead of raw pointer

This is a good idea in general, because it makes ownership clearer,
but will also be very convenient when scoped_ptr is gone, since
unique_ptr doesn't have an .accept() method.

BUG=webrtc:5520

Committed: https://crrev.com/6baec0351aab267fb4f07b95778ae2e5f0d58f05
Cr-Commit-Position: refs/heads/master@{#12002}
==========

[commit-bot: I haz the power, 2016-03-15 18:10:03]

Patchset 2 (id:??) landed as
https://crrev.com/6baec0351aab267fb4f07b95778ae2e5f0d58f05
Cr-Commit-Position: refs/heads/master@{#12002}