Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 1799443006: Rename RTCIceConnectionStateMax to RTCIceConnectionStateCount (Closed)

Created:
4 years, 9 months ago by hjon_webrtc
Modified:
4 years, 9 months ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename RTCIceConnectionStateMax to RTCIceConnectionStateCount in Objective-C API. BUG= Committed: https://crrev.com/8bbbf2c3daa6c208ab778d859249e972f477edf2 Cr-Commit-Position: refs/heads/master@{#11987}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changes based on feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M webrtc/api/objc/RTCPeerConnection.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/api/objc/RTCPeerConnection.mm View 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/examples/objc/AppRTCDemo/ios/ARDVideoCallViewController.m View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
hjon_webrtc
Per the suggestion from the updated AppRTCDemo CL: https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppRTCDemo/ios/ARDVideoCallViewController.m#newcode182
4 years, 9 months ago (2016-03-14 14:48:24 UTC) #3
tkchin_webrtc
lgtm https://codereview.webrtc.org/1799443006/diff/1/webrtc/api/objc/RTCPeerConnection.h File webrtc/api/objc/RTCPeerConnection.h (right): https://codereview.webrtc.org/1799443006/diff/1/webrtc/api/objc/RTCPeerConnection.h#newcode48 webrtc/api/objc/RTCPeerConnection.h:48: RTCIceConnectionStateCount, add a comment like: // Not an ...
4 years, 9 months ago (2016-03-14 17:09:32 UTC) #4
hjon_webrtc
ptal https://codereview.webrtc.org/1799443006/diff/1/webrtc/api/objc/RTCPeerConnection.h File webrtc/api/objc/RTCPeerConnection.h (right): https://codereview.webrtc.org/1799443006/diff/1/webrtc/api/objc/RTCPeerConnection.h#newcode48 webrtc/api/objc/RTCPeerConnection.h:48: RTCIceConnectionStateCount, On 2016/03/14 17:09:32, tkchin_webrtc wrote: > add ...
4 years, 9 months ago (2016-03-14 17:20:28 UTC) #5
tkchin_webrtc
lgtm
4 years, 9 months ago (2016-03-14 17:30:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1799443006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1799443006/20001
4 years, 9 months ago (2016-03-14 17:34:18 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-14 20:15:48 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 20:15:59 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8bbbf2c3daa6c208ab778d859249e972f477edf2
Cr-Commit-Position: refs/heads/master@{#11987}

Powered by Google App Engine
This is Rietveld 408576698