Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: webrtc/base/fakesslidentity.h

Issue 1799233002: SSLCertificate::GetChain: Return scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: No auto Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/statscollector.cc ('k') | webrtc/base/opensslidentity.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/fakesslidentity.h
diff --git a/webrtc/base/fakesslidentity.h b/webrtc/base/fakesslidentity.h
index ec603a541d847a426dc08261ec1720605db60201..47ff86d03a827ebdf3a9a72f0bb6bf65ae278609 100644
--- a/webrtc/base/fakesslidentity.h
+++ b/webrtc/base/fakesslidentity.h
@@ -68,14 +68,14 @@ class FakeSSLCertificate : public rtc::SSLCertificate {
digest, size);
return (*length != 0);
}
- virtual bool GetChain(SSLCertChain** chain) const {
+ virtual rtc::scoped_ptr<SSLCertChain> GetChain() const {
if (certs_.empty())
- return false;
+ return nullptr;
std::vector<SSLCertificate*> new_certs(certs_.size());
std::transform(certs_.begin(), certs_.end(), new_certs.begin(), DupCert);
- *chain = new SSLCertChain(new_certs);
+ rtc::scoped_ptr<SSLCertChain> chain(new SSLCertChain(new_certs));
std::for_each(new_certs.begin(), new_certs.end(), DeleteCert);
- return true;
+ return chain;
}
private:
« no previous file with comments | « webrtc/api/statscollector.cc ('k') | webrtc/base/opensslidentity.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698