webrtc/api/statscollector.cc - Issue 1799233002: SSLCertificate::GetChain: Return scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/api/statscollector.cc

Issue 1799233002: SSLCertificate::GetChain: Return scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: No auto Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/api/statscollector.cc

diff --git a/webrtc/api/statscollector.cc b/webrtc/api/statscollector.cc

index 7fb0c2b7b3aef4946ddd9e73546dcab22c3c2f90..d77953b3bed1d49bb75a3be6a35c5d10f91c382b 100644

--- a/webrtc/api/statscollector.cc

+++ b/webrtc/api/statscollector.cc

@@ -575,8 +575,8 @@ StatsReport* StatsCollector::AddCertificateReports(

RTC_DCHECK(cert != NULL);

StatsReport* issuer = nullptr;

- rtc::scoped_ptr<rtc::SSLCertChain> chain;

- if (cert->GetChain(chain.accept())) {

+ rtc::scoped_ptr<rtc::SSLCertChain> chain = cert->GetChain();

+ if (chain) {

// This loop runs in reverse, i.e. from root to leaf, so that each

// certificate's issuer's report ID is known before the child certificate's

// report is generated. The root certificate does not have an issuer ID

« no previous file with comments | « no previous file | webrtc/base/fakesslidentity.h » ('j') | no next file with comments »