SSLCertificate::GetChain: Return scoped_ptr

webrtc/base/fakesslidentity.h

Index: webrtc/base/fakesslidentity.h
diff --git a/webrtc/base/fakesslidentity.h b/webrtc/base/fakesslidentity.h
index ec603a541d847a426dc08261ec1720605db60201..212fd37d5774f57ca75d8c2fbd1e943520ea428f 100644
--- a/webrtc/base/fakesslidentity.h
+++ b/webrtc/base/fakesslidentity.h
@@ -68,14 +68,14 @@ class FakeSSLCertificate : public rtc::SSLCertificate {
                                        digest, size);
     return (*length != 0);
   }
-  virtual bool GetChain(SSLCertChain** chain) const {
+  virtual rtc::scoped_ptr<SSLCertChain> GetChain() const {
     if (certs_.empty())
-      return false;
+      return nullptr;
     std::vector<SSLCertificate*> new_certs(certs_.size());
     std::transform(certs_.begin(), certs_.end(), new_certs.begin(), DupCert);
-    *chain = new SSLCertChain(new_certs);
+    auto chain = rtc::scoped_ptr<SSLCertChain>(new SSLCertChain(new_certs));

[tommi, 2016/03/15 09:26:55]

Use of auto feels a bit forced here. Just use the full type and ctor syntax.

[kwiberg-webrtc, 2016/03/15 10:06:39]

Right, that's actually shorter. Will do.

     std::for_each(new_certs.begin(), new_certs.end(), DeleteCert);
-    return true;
+    return chain;
   }
 
  private: