Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issue 1799103002: Use the right mirroring state when switching cameras in AppRTCDemo. (Closed)

Created:
4 years, 9 months ago by hjon_webrtc
Modified:
4 years, 9 months ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use the right mirroring state when switching cameras in AppRTCDemo. BUG= Committed: https://crrev.com/a9635b83e0bcfdddcda9235a37c0fe7c6934e363 Cr-Commit-Position: refs/heads/master@{#11988}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M webrtc/examples/objc/AppRTCDemo/ios/ARDVideoCallViewController.m View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
hjon_webrtc
I noticed that switching the camera in AppRTCDemo to the back camera, then back to ...
4 years, 9 months ago (2016-03-14 15:13:00 UTC) #2
tkchin_webrtc
yeah, this should've been deleted when we switched to the AVCapturePreviewLayer class. lgtm
4 years, 9 months ago (2016-03-14 18:11:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1799103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1799103002/1
4 years, 9 months ago (2016-03-14 18:13:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-14 20:43:39 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 20:43:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a9635b83e0bcfdddcda9235a37c0fe7c6934e363
Cr-Commit-Position: refs/heads/master@{#11988}

Powered by Google App Engine
This is Rietveld 408576698