Helpers in peer connection unit tests: Use scoped_ptr instead of raw pointers

Helpers in peer connection unit tests: Use scoped_ptr instead of raw pointers

A handful of helpers were using SessionDescriptionInterface** output
arguments to return ownership. Chenge them to either use a
rtc::scoped_ptr<SessionDescriptionInterface>* output parameter, or to
simply return a rtc::scoped_ptr<SessionDescriptionInterface>. Not
using raw pointers for things you own is good in general; it will also
be very convenient when scoped_ptr is gone, since unique_ptr doesn't
have .accept() or .use() methods.

BUG=webrtc:5520
Committed: https://crrev.com/2bbff996a6c9851524f63c015c4590d34c517eda
Cr-Commit-Position: refs/heads/master@{#12021}

[kwiberg-webrtc, 2016-03-16 13:57:54]

Description was changed from

==========
Helpers in peer connection unit tests: Use scoped_ptr instead of raw pointers

A handful of helpers were using SessionDescriptionInterface** output
arguments to return ownership. Chenge them to either use a
rtc::scoped_ptr<SessionDescriptionInterface>* output parameter, or to
simply return a rtc::scoped_ptr<SessionDescriptionInterface>. That
this is a good idea is immediately obvious here, since the change
unearthed a couple places where the returned pointer was stored in a
raw pointer that we forgot to delete. It will also be very convenient
when scoped_ptr is gone, since unique_ptr doesn't have .accept() or
.use() methods.

BUG=webrtc:5520
==========

to

==========
Helpers in peer connection unit tests: Use scoped_ptr instead of raw pointers

A handful of helpers were using SessionDescriptionInterface** output
arguments to return ownership. Chenge them to either use a
rtc::scoped_ptr<SessionDescriptionInterface>* output parameter, or to
simply return a rtc::scoped_ptr<SessionDescriptionInterface>. Not
using raw pointers for things you own is good in general; it will also
be very convenient when scoped_ptr is gone, since unique_ptr doesn't
have .accept() or .use() methods.

BUG=webrtc:5520
==========

[kwiberg-webrtc, 2016-03-16 14:18:56]

kwiberg@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[pthatcher1, 2016-03-16 15:43:49]

lgtm

[kwiberg-webrtc, 2016-03-16 17:45:39]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2016-03-16 17:45:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1798173002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1798173002/20001

[commit-bot: I haz the power, 2016-03-16 18:03:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-16 18:03:12]

Description was changed from

==========
Helpers in peer connection unit tests: Use scoped_ptr instead of raw pointers

A handful of helpers were using SessionDescriptionInterface** output
arguments to return ownership. Chenge them to either use a
rtc::scoped_ptr<SessionDescriptionInterface>* output parameter, or to
simply return a rtc::scoped_ptr<SessionDescriptionInterface>. Not
using raw pointers for things you own is good in general; it will also
be very convenient when scoped_ptr is gone, since unique_ptr doesn't
have .accept() or .use() methods.

BUG=webrtc:5520
==========

to

==========
Helpers in peer connection unit tests: Use scoped_ptr instead of raw pointers

A handful of helpers were using SessionDescriptionInterface** output
arguments to return ownership. Chenge them to either use a
rtc::scoped_ptr<SessionDescriptionInterface>* output parameter, or to
simply return a rtc::scoped_ptr<SessionDescriptionInterface>. Not
using raw pointers for things you own is good in general; it will also
be very convenient when scoped_ptr is gone, since unique_ptr doesn't
have .accept() or .use() methods.

BUG=webrtc:5520

Committed: https://crrev.com/2bbff996a6c9851524f63c015c4590d34c517eda
Cr-Commit-Position: refs/heads/master@{#12021}
==========

[commit-bot: I haz the power, 2016-03-16 18:03:13]

Patchset 2 (id:??) landed as
https://crrev.com/2bbff996a6c9851524f63c015c4590d34c517eda
Cr-Commit-Position: refs/heads/master@{#12021}