Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 1797463002: Make rtc::scoped_ptr a type alias for std::unique_ptr (Closed)

Created:
4 years, 9 months ago by kwiberg-webrtc
Modified:
4 years, 7 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make rtc::scoped_ptr a type alias for std::unique_ptr There's also one fixup that could neither be done before or after landing the type alias CL: changing the FunctorMessageHandler template specialization for rtc::scoped_ptr<ReturnT> to be for std::unique_ptr<ReturnT> instead. (Having one specialization for scoped_ptr and one for unique_ptr doesn't work when the types are the same, and having just the scoped_ptr specialization doesn't work when scoped_ptr is a type alias. I'm sure there's some template metaprogramming magic that could solve the problem, but it's easy enough to just make the change in this CL instead.) BUG=webrtc:5520 Committed: https://crrev.com/ba5ea44bad712d454504f55bbcd347494ba9c188 Cr-Commit-Position: refs/heads/master@{#12499}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -593 lines) Patch
M webrtc/base/messagehandler.h View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/base/scoped_ptr.h View 2 chunks +12 lines, -589 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
tommi
lgtm
4 years, 8 months ago (2016-04-08 14:00:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1797463002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1797463002/100001
4 years, 7 months ago (2016-04-26 01:07:04 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:100001)
4 years, 7 months ago (2016-04-26 01:08:44 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-04-26 01:08:55 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba5ea44bad712d454504f55bbcd347494ba9c188
Cr-Commit-Position: refs/heads/master@{#12499}

Powered by Google App Engine
This is Rietveld 408576698