webrtc/modules/audio_device/ios/objc/RTCAudioSession+Configuration.mm - Issue 1796983004: Use RTCAudioSessionDelegate in AudioDeviceIOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_device/ios/objc/RTCAudioSession+Configuration.mm

Issue 1796983004: Use RTCAudioSessionDelegate in AudioDeviceIOS. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Some nits. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm ('k') | webrtc/modules/audio_device/ios/objc/RTCAudioSession+Private.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_device/ios/objc/RTCAudioSession+Configuration.mm

diff --git a/webrtc/modules/audio_device/ios/objc/RTCAudioSession+Configuration.mm b/webrtc/modules/audio_device/ios/objc/RTCAudioSession+Configuration.mm

index 7b0bb586396860bd558aa48073c5db52d4d1feb0..83320b62f08d52a5f4bf5c23a78a30b7d8dcfb54 100644

--- a/webrtc/modules/audio_device/ios/objc/RTCAudioSession+Configuration.mm

+++ b/webrtc/modules/audio_device/ios/objc/RTCAudioSession+Configuration.mm

@@ -49,7 +49,8 @@

}

- if (self.sampleRate != configuration.sampleRate) {

+ // self.sampleRate is accurate only if the audio session is active.

+ if (!self.isActive || self.sampleRate != configuration.sampleRate) {

NSError *sampleRateError = nil;

if (![self setPreferredSampleRate:configuration.sampleRate

error:&sampleRateError]) {

@@ -59,7 +60,9 @@

}

- if (self.IOBufferDuration != configuration.ioBufferDuration) {

+ // self.IOBufferDuration is accurate only if the audio session is active.

+ if (!self.isActive ||

+ self.IOBufferDuration != configuration.ioBufferDuration) {

NSError *bufferDurationError = nil;

if (![self setPreferredIOBufferDuration:configuration.ioBufferDuration

error:&bufferDurationError]) {