Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1796953002: Add breaks in switch statement to fix AppRTCDemo crash (Closed)

Created:
4 years, 9 months ago by hjon_webrtc
Modified:
4 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add breaks in switch statement to fix AppRTCDemo crash BUG= Committed: https://crrev.com/c4ec4a2e516ce111fc1ad1f905f1877e2cd2e733 Cr-Commit-Position: refs/heads/master@{#11989}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M webrtc/examples/objc/AppRTCDemo/ARDSignalingMessage.m View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
hjon_webrtc
4 years, 9 months ago (2016-03-14 18:18:57 UTC) #2
tkchin_webrtc
lgtm
4 years, 9 months ago (2016-03-14 18:19:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1796953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1796953002/1
4 years, 9 months ago (2016-03-14 19:13:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 9 months ago (2016-03-14 21:14:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1796953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1796953002/1
4 years, 9 months ago (2016-03-14 21:36:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-14 21:56:51 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c4ec4a2e516ce111fc1ad1f905f1877e2cd2e733 Cr-Commit-Position: refs/heads/master@{#11989}
4 years, 9 months ago (2016-03-14 21:57:02 UTC) #12
henrika_webrtc
4 years, 9 months ago (2016-03-15 08:54:45 UTC) #13
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698