Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 1796413002: Add check_deps rules in DEPS files. (Closed)

Created:
4 years, 9 months ago by kjellander_webrtc
Modified:
4 years, 9 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), zhuangzesen_agora.io, tlegrand-webrtc, qiang.lu, peah-webrtc, bjornv1, video-team_agora.io, tterriberry_mozilla.com, fengyue_agora.io, sdk-team_agora.io, minyue-webrtc, mflodman, Andrew MacDonald, zhengzhonghou_agora.io, stefan-webrtc, kwiberg-webrtc, danilchap, henrika_webrtc, audio-team_agora.io, hlundin-webrtc, niklas.enbom, the sun, pbos-webrtc, perkj_webrtc, aluebs-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add check_deps rules in DEPS files. Add fine-grained check_deps rules for all of WebRTC. This will help both maintaining sane dependencies and provides a way to visualize dependency graphs using the buildtools/checkdeps/graphdeps.py script. Example: buildtools/checkdeps/graphdeps.py --root=. --format=png \ --out=./webrtc.png --incl='^webrtc/modules/bitrate_controller->' \ --excl='chromium|base|external|testing|webrtc/test|\.h$|\.cc$' will produce a neat webrtc.png image showcasing the dependencies (according to the DEPS file) for the bitrate_controller module. Some dependencies are filtered out for readability. BUG=webrtc:5623 TESTED=Passing runs using: buildtools/checkdeps/checkdeps.py --root=. talk buildtools/checkdeps/checkdeps.py --root=. webrtc R=tommi@webrtc.org Committed: https://crrev.com/086f851b7b9b4bcbd4fe507c3bf83b760bd7f4d9 Cr-Commit-Position: refs/heads/master@{#12008}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Fixed nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+348 lines, -306 lines) Patch
M DEPS View 1 chunk +0 lines, -19 lines 0 comments Download
A talk/app/webrtc/DEPS View 1 chunk +7 lines, -0 lines 0 comments Download
A webrtc/DEPS View 1 chunk +47 lines, -0 lines 0 comments Download
A webrtc/api/DEPS View 1 chunk +23 lines, -0 lines 0 comments Download
A webrtc/audio/DEPS View 1 chunk +10 lines, -0 lines 0 comments Download
A webrtc/base/DEPS View 1 1 chunk +11 lines, -0 lines 0 comments Download
A webrtc/call/DEPS View 1 chunk +13 lines, -0 lines 0 comments Download
A webrtc/common_audio/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/common_audio/real_fourier_openmax.cc View 1 chunk +1 line, -1 line 0 comments Download
A webrtc/common_video/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A webrtc/examples/DEPS View 1 chunk +7 lines, -0 lines 0 comments Download
A webrtc/libjingle/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
D webrtc/libjingle/xmpp/chatroommodule_unittest.cc View 1 chunk +0 lines, -280 lines 0 comments Download
A webrtc/media/DEPS View 1 chunk +22 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/DEPS View 1 chunk +7 lines, -0 lines 0 comments Download
A webrtc/modules/audio_conference_mixer/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A webrtc/modules/audio_device/DEPS View 1 chunk +11 lines, -0 lines 0 comments Download
A webrtc/modules/audio_processing/DEPS View 1 chunk +14 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/agc/agc_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/agc/mock_agc.h View 1 chunk +1 line, -1 line 0 comments Download
A webrtc/modules/bitrate_controller/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
A webrtc/modules/congestion_controller/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
A webrtc/modules/desktop_capture/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A webrtc/modules/include/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A webrtc/modules/media_file/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
A webrtc/modules/pacing/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A webrtc/modules/remote_bitrate_estimator/DEPS View 1 chunk +10 lines, -0 lines 0 comments Download
A webrtc/modules/rtp_rtcp/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
A webrtc/modules/utility/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
A webrtc/modules/video_capture/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/DEPS View 1 chunk +9 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h View 2 chunks +1 line, -2 lines 0 comments Download
A webrtc/modules/video_processing/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
A webrtc/p2p/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
A webrtc/pc/DEPS View 1 chunk +13 lines, -0 lines 0 comments Download
A webrtc/sound/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A webrtc/system_wrappers/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A webrtc/test/DEPS View 1 chunk +13 lines, -0 lines 0 comments Download
A webrtc/tools/DEPS View 1 chunk +8 lines, -0 lines 0 comments Download
A webrtc/video/DEPS View 1 chunk +17 lines, -0 lines 0 comments Download
A webrtc/voice_engine/DEPS View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
kjellander_webrtc
4 years, 9 months ago (2016-03-15 13:55:49 UTC) #6
kjellander_webrtc
+cc solenberg. This was quite some work but nice to get it in place. Unfortunately ...
4 years, 9 months ago (2016-03-15 13:58:11 UTC) #7
tommi
lgtm https://codereview.webrtc.org/1796413002/diff/40001/webrtc/base/DEPS File webrtc/base/DEPS (right): https://codereview.webrtc.org/1796413002/diff/40001/webrtc/base/DEPS#newcode6 webrtc/base/DEPS:6: nit: one space
4 years, 9 months ago (2016-03-15 17:06:15 UTC) #8
kjellander_webrtc
Fixed nit, I was also able to generate graphs now. I'll add that to the ...
4 years, 9 months ago (2016-03-16 00:20:33 UTC) #9
kjellander_webrtc
Committed patchset #2 (id:60001) manually as 086f851b7b9b4bcbd4fe507c3bf83b760bd7f4d9 (presubmit successful).
4 years, 9 months ago (2016-03-16 00:22:59 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/086f851b7b9b4bcbd4fe507c3bf83b760bd7f4d9 Cr-Commit-Position: refs/heads/master@{#12008}
4 years, 9 months ago (2016-03-16 00:23:01 UTC) #16
kjellander_webrtc
4 years, 9 months ago (2016-03-16 00:40:42 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:60001) has been created in
https://codereview.webrtc.org/1808573002/ by kjellander@webrtc.org.

The reason for reverting is: The openmax_dl include change breaks downstream
projects..

Powered by Google App Engine
This is Rietveld 408576698