Using 64-bit timestamp in webrtc/p2p

Using 64-bit timestamp to replace the 32-bit one in webrtc/p2p.
Also changed from unsigned to signed integer per the style guide.
By the way, I kept all delta-times to be 32-bit int.

The only things left in the p2p dir are
1. proberprober/main.cc where Time() is used as the input for a random number.
2. pseudotcp.cc: where 32-bit time info is sent over the wire.

BUG=webrtc:5636
Committed: https://crrev.com/34b11eb66e538092a938db6f1e6fc973341941c6
Cr-Commit-Position: refs/heads/master@{#12019}

[honghaiz3, 2016-03-14 21:07:14]

Patchset #2 (id:20001) has been deleted

[honghaiz3, 2016-03-14 21:07:24]

Patchset #1 (id:1) has been deleted

[honghaiz3, 2016-03-14 22:31:43]

Patchset #1 (id:40001) has been deleted

[honghaiz3, 2016-03-14 22:33:39]

Patchset #1 (id:60001) has been deleted

[honghaiz3, 2016-03-14 22:35:58]

honghaiz@webrtc.org changed reviewers:
+ deadbeef@webrtc.org, pthatcher@webrtc.org

[honghaiz3, 2016-03-14 22:36:00]

PTAL. Thanks!

https://codereview.webrtc.org/1793553002/diff/80001/webrtc/p2p/base/faketrans...
File webrtc/p2p/base/faketransportcontroller.h (right):

https://codereview.webrtc.org/1793553002/diff/80001/webrtc/p2p/base/faketrans...
webrtc/p2p/base/faketransportcontroller.h:208: rtc::SentPacket
sent_packet(options.packet_id, rtc::Time64());
SentPacket take int64_t as the second parameter, so we can use Time64() there
directly.

[honghaiz3, 2016-03-14 22:41:47]

Description was changed from

==========
Using 64-bit timestamp in webrtc/p2p

BUG=
==========

to

==========
Using 64-bit timestamp to replace the 32-bit one in webrtc/p2p. 
Also changed from unsigned to signed integer per the style guide. 

The only things left in the p2p dir are
1. proberprober/main.cc where Time() is used as the input for a random number. 
2. pseudotcp.cc: where 32-bit time info is sent over the wire.  

BUG=webrtc:5636
==========

[honghaiz3, 2016-03-14 22:53:22]

Description was changed from

==========
Using 64-bit timestamp to replace the 32-bit one in webrtc/p2p. 
Also changed from unsigned to signed integer per the style guide. 

The only things left in the p2p dir are
1. proberprober/main.cc where Time() is used as the input for a random number. 
2. pseudotcp.cc: where 32-bit time info is sent over the wire.  

BUG=webrtc:5636
==========

to

==========
Using 64-bit timestamp to replace the 32-bit one in webrtc/p2p. 
Also changed from unsigned to signed integer per the style guide. 
By the way, I kept all delta-times to be 32-bit int.  

The only things left in the p2p dir are
1. proberprober/main.cc where Time() is used as the input for a random number. 
2. pseudotcp.cc: where 32-bit time info is sent over the wire.  

BUG=webrtc:5636
==========

[pthatcher1, 2016-03-15 04:10:50]

https://codereview.webrtc.org/1793553002/diff/80001/webrtc/base/timeutils.h
File webrtc/base/timeutils.h (right):

https://codereview.webrtc.org/1793553002/diff/80001/webrtc/base/timeutils.h#n...
webrtc/base/timeutils.h:38: uint32_t Time();
Can you make a Time32() that chooses 32-bit time, and then make Time() call
Time32() for now, but then later change the remaining callers of Time() to be
Time32(), and then change Time() to call Time64()?

And can you also put a TODO here saying that's what you are going to do?  That
way, we'll eventually be in a state where everything can call Time() with the
right size, and only get 32-bit if it asks for it with Time32().

In fact, we should probably go back and rename all the calls to Time64() to be
Time() as well.

https://codereview.webrtc.org/1793553002/diff/80001/webrtc/base/timeutils.h#n...
webrtc/base/timeutils.h:77: int64_t TimeDiff64(int64_t later, int64_t earlier);
Same here with the names: make TimeDiff64 the default and 32 the strange one.

https://codereview.webrtc.org/1793553002/diff/80001/webrtc/p2p/base/turnserve...
File webrtc/p2p/base/turnserver.cc (right):

https://codereview.webrtc.org/1793553002/diff/80001/webrtc/p2p/base/turnserve...
webrtc/p2p/base/turnserver.cc:38: static const size_t kNonceSize = 48;
Why do we need to change the nonce size?

[honghaiz3, 2016-03-15 17:35:33]

PTAL.

https://codereview.webrtc.org/1793553002/diff/80001/webrtc/base/timeutils.h
File webrtc/base/timeutils.h (right):

https://codereview.webrtc.org/1793553002/diff/80001/webrtc/base/timeutils.h#n...
webrtc/base/timeutils.h:38: uint32_t Time();
On 2016/03/15 04:10:50, pthatcher1 wrote:
> Can you make a Time32() that chooses 32-bit time, and then make Time() call
> Time32() for now, but then later change the remaining callers of Time() to be
> Time32(), and then change Time() to call Time64()?
> 
> And can you also put a TODO here saying that's what you are going to do?  That
> way, we'll eventually be in a state where everything can call Time() with the
> right size, and only get 32-bit if it asks for it with Time32().
> 
> In fact, we should probably go back and rename all the calls to Time64() to be
> Time() as well. 

Done. The last item will be done in the next CL when we switch the default from
32bit to 64bit time.

https://codereview.webrtc.org/1793553002/diff/80001/webrtc/base/timeutils.h#n...
webrtc/base/timeutils.h:77: int64_t TimeDiff64(int64_t later, int64_t earlier);
On 2016/03/15 04:10:50, pthatcher1 wrote:
> Same here with the names: make TimeDiff64 the default and 32 the strange one.
Will do this in the next CL because many of the 32-bit methods including
TimeDiff may be removed at all (The implementation is extremely simple. The only
reason to keep them is to support the legacy call).

https://codereview.webrtc.org/1793553002/diff/80001/webrtc/p2p/base/turnserve...
File webrtc/p2p/base/turnserver.cc (right):

https://codereview.webrtc.org/1793553002/diff/80001/webrtc/p2p/base/turnserve...
webrtc/p2p/base/turnserver.cc:38: static const size_t kNonceSize = 48;
On 2016/03/15 04:10:50, pthatcher1 wrote:
> Why do we need to change the nonce size?

Nonce is generated from timestamp. As timestamp changes from int to int64, the
nonce size changed from 40 bytes to 48 bytes.
We could still use 32-bit timestamp to generate a 40-byte nonce, although it may
look strange after the timestamp migration.

[pthatcher1, 2016-03-15 18:07:11]

lgtm

[honghaiz3, 2016-03-16 15:53:57]

The CQ bit was checked by honghaiz@webrtc.org

[commit-bot: I haz the power, 2016-03-16 15:54:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1793553002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1793553002/100001

[commit-bot: I haz the power, 2016-03-16 15:55:47]

Description was changed from

==========
Using 64-bit timestamp to replace the 32-bit one in webrtc/p2p. 
Also changed from unsigned to signed integer per the style guide. 
By the way, I kept all delta-times to be 32-bit int.  

The only things left in the p2p dir are
1. proberprober/main.cc where Time() is used as the input for a random number. 
2. pseudotcp.cc: where 32-bit time info is sent over the wire.  

BUG=webrtc:5636
==========

to

==========
Using 64-bit timestamp to replace the 32-bit one in webrtc/p2p. 
Also changed from unsigned to signed integer per the style guide. 
By the way, I kept all delta-times to be 32-bit int.  

The only things left in the p2p dir are
1. proberprober/main.cc where Time() is used as the input for a random number. 
2. pseudotcp.cc: where 32-bit time info is sent over the wire.  

BUG=webrtc:5636
==========

[commit-bot: I haz the power, 2016-03-16 15:55:48]

Committed patchset #2 (id:100001)

[commit-bot: I haz the power, 2016-03-16 15:55:53]

Description was changed from

==========
Using 64-bit timestamp to replace the 32-bit one in webrtc/p2p. 
Also changed from unsigned to signed integer per the style guide. 
By the way, I kept all delta-times to be 32-bit int.  

The only things left in the p2p dir are
1. proberprober/main.cc where Time() is used as the input for a random number. 
2. pseudotcp.cc: where 32-bit time info is sent over the wire.  

BUG=webrtc:5636
==========

to

==========
Using 64-bit timestamp to replace the 32-bit one in webrtc/p2p.
Also changed from unsigned to signed integer per the style guide.
By the way, I kept all delta-times to be 32-bit int.

The only things left in the p2p dir are
1. proberprober/main.cc where Time() is used as the input for a random number.
2. pseudotcp.cc: where 32-bit time info is sent over the wire.

BUG=webrtc:5636

Committed: https://crrev.com/34b11eb66e538092a938db6f1e6fc973341941c6
Cr-Commit-Position: refs/heads/master@{#12019}
==========

[commit-bot: I haz the power, 2016-03-16 15:55:54]

Patchset 2 (id:??) landed as
https://crrev.com/34b11eb66e538092a938db6f1e6fc973341941c6
Cr-Commit-Position: refs/heads/master@{#12019}

[honghaiz3, 2016-03-17 02:26:28]

honghaiz@webrtc.org changed reviewers:
+ glaznev@webrtc.org

[honghaiz3, 2016-03-17 02:52:43]

Description was changed from

==========
Using 64-bit timestamp to replace the 32-bit one in webrtc/p2p.
Also changed from unsigned to signed integer per the style guide.
By the way, I kept all delta-times to be 32-bit int.

The only things left in the p2p dir are
1. proberprober/main.cc where Time() is used as the input for a random number.
2. pseudotcp.cc: where 32-bit time info is sent over the wire.

BUG=webrtc:5636

Committed: https://crrev.com/34b11eb66e538092a938db6f1e6fc973341941c6
Cr-Commit-Position: refs/heads/master@{#12019}
==========

to

==========
Using 64-bit timestamp to replace the 32-bit one in webrtc/p2p.
Also changed from unsigned to signed integer per the style guide.
By the way, I kept all delta-times to be 32-bit int.

The only things left in the p2p dir are
1. proberprober/main.cc where Time() is used as the input for a random number.
2. pseudotcp.cc: where 32-bit time info is sent over the wire.

BUG=webrtc:5636

Committed: https://crrev.com/34b11eb66e538092a938db6f1e6fc973341941c6
Cr-Commit-Position: refs/heads/master@{#12019}
==========

[honghaiz3, 2016-03-17 02:52:43]

honghaiz@webrtc.org changed reviewers:
- glaznev@webrtc.org