Reconfigure video encoders even when not sending.

Reconfigure video encoders even when not sending.

Permits sending faster when having an attached track before actually
sending since the configured stream is ready to encode as soon as a call
is accepted.

BUG=webrtc:5410
R=deadbeef@webrtc.org

Committed: https://crrev.com/e7ba08695c0f3bd2a4140ef20a681a5436a3b1f8
Cr-Commit-Position: refs/heads/master@{#11963}

[pbos-webrtc, 2016-03-11 21:21:16]

PTAL

[pbos-webrtc, 2016-03-11 21:21:22]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-11 21:21:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1790703002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1790703002/1

[commit-bot: I haz the power, 2016-03-11 21:32:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 21:32:18]

Dry run: Try jobs failed on following builders:
  win_compile_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_compile_dbg/builds/...)

[Taylor Brandstetter, 2016-03-11 21:33:29]

lgtm

https://codereview.webrtc.org/1790703002/diff/1/webrtc/media/engine/webrtcvid...
File webrtc/media/engine/webrtcvideoengine2.cc (right):

https://codereview.webrtc.org/1790703002/diff/1/webrtc/media/engine/webrtcvid...
webrtc/media/engine/webrtcvideoengine2.cc:1574: // occur to permit sending this
input as quickly as possible once we go
nit: "go to" sending or "start" sending

https://codereview.webrtc.org/1790703002/diff/1/webrtc/media/engine/webrtcvid...
File webrtc/media/engine/webrtcvideoengine2_unittest.cc (right):

https://codereview.webrtc.org/1790703002/diff/1/webrtc/media/engine/webrtcvid...
webrtc/media/engine/webrtcvideoengine2_unittest.cc:1487:
TEST_F(WebRtcVideoChannel2Test, ReconfiguresEncodersWhenNotSending) {
nit: Even though the name is pretty clear, a comment could be added clarifying
what this test is verifying.

[pbos-webrtc, 2016-03-11 22:50:39]

feedback + compile

[pbos-webrtc, 2016-03-11 22:50:42]

https://codereview.webrtc.org/1790703002/diff/1/webrtc/media/engine/webrtcvid...
File webrtc/media/engine/webrtcvideoengine2.cc (right):

https://codereview.webrtc.org/1790703002/diff/1/webrtc/media/engine/webrtcvid...
webrtc/media/engine/webrtcvideoengine2.cc:1574: // occur to permit sending this
input as quickly as possible once we go
On 2016/03/11 21:33:29, Taylor Brandstetter wrote:
> nit: "go to" sending or "start" sending

Done.

https://codereview.webrtc.org/1790703002/diff/1/webrtc/media/engine/webrtcvid...
File webrtc/media/engine/webrtcvideoengine2_unittest.cc (right):

https://codereview.webrtc.org/1790703002/diff/1/webrtc/media/engine/webrtcvid...
webrtc/media/engine/webrtcvideoengine2_unittest.cc:1487:
TEST_F(WebRtcVideoChannel2Test, ReconfiguresEncodersWhenNotSending) {
On 2016/03/11 21:33:29, Taylor Brandstetter wrote:
> nit: Even though the name is pretty clear, a comment could be added clarifying
> what this test is verifying.

Done.

[pbos-webrtc, 2016-03-11 23:02:40]

Description was changed from

==========
Reconfigure video encoders even when not sending.

Permits sending faster when having an attached track before actually
sending since the configured stream is ready to encode as soon as a call
is accepted.

BUG=webrtc:5410
R=deadbeef@webrtc.org
==========

to

==========
Reconfigure video encoders even when not sending.

Permits sending faster when having an attached track before actually
sending since the configured stream is ready to encode as soon as a call
is accepted.

BUG=webrtc:5410
R=deadbeef@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/e7ba08695c0f3bd2a4140ef20...
==========

[pbos-webrtc, 2016-03-11 23:02:42]

Committed patchset #2 (id:20001) manually as
e7ba08695c0f3bd2a4140ef20a681a5436a3b1f8 (presubmit successful).

[commit-bot: I haz the power, 2016-03-11 23:02:46]

Description was changed from

==========
Reconfigure video encoders even when not sending.

Permits sending faster when having an attached track before actually
sending since the configured stream is ready to encode as soon as a call
is accepted.

BUG=webrtc:5410
R=deadbeef@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/e7ba08695c0f3bd2a4140ef20...
==========

to

==========
Reconfigure video encoders even when not sending.

Permits sending faster when having an attached track before actually
sending since the configured stream is ready to encode as soon as a call
is accepted.

BUG=webrtc:5410
R=deadbeef@webrtc.org

Committed: https://crrev.com/e7ba08695c0f3bd2a4140ef20a681a5436a3b1f8
Cr-Commit-Position: refs/heads/master@{#11963}
==========

[commit-bot: I haz the power, 2016-03-11 23:02:47]

Patchset 2 (id:??) landed as
https://crrev.com/e7ba08695c0f3bd2a4140ef20a681a5436a3b1f8
Cr-Commit-Position: refs/heads/master@{#11963}