webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc - Issue 1788783002: Add macros for ability to log samples that are added to histograms (RTC_LOGGED_*).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc

Issue 1788783002: Add macros for ability to log samples that are added to histograms (RTC_LOGGED_*). (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc ('k') | webrtc/modules/video_coding/jitter_buffer.cc » ('j') | webrtc/system_wrappers/include/metrics.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc

diff --git a/webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc b/webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc

index 869657b972d08ca795794d0d4cec7a6e2824bbc9..2b7f7195d54bcf822606ce93848e07ba207095c5 100644

--- a/webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc

+++ b/webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc

@@ -315,14 +315,14 @@ void ScreenshareLayers::UpdateHistograms() {

"WebRTC.Video.Screenshare.Layer1.FrameRate",

(stats_.num_tl1_frames_ + (duration_sec / 2)) / duration_sec);

int total_frames = stats_.num_tl0_frames_ + stats_.num_tl1_frames_;

- RTC_HISTOGRAM_COUNTS_10000("WebRTC.Video.Screenshare.FramesPerDrop",

- stats_.num_dropped_frames_ == 0

- ? 0

- : total_frames / stats_.num_dropped_frames_);

- RTC_HISTOGRAM_COUNTS_10000("WebRTC.Video.Screenshare.FramesPerOvershoot",

- stats_.num_overshoots_ == 0

- ? 0

- : total_frames / stats_.num_overshoots_);

+ RTC_HISTOGRAM_COUNTS_10000(

+ "WebRTC.Video.Screenshare.FramesPerDrop",

+ (stats_.num_dropped_frames_ == 0 ? 0 : total_frames /

+ stats_.num_dropped_frames_));

+ RTC_HISTOGRAM_COUNTS_10000(

+ "WebRTC.Video.Screenshare.FramesPerOvershoot",

+ (stats_.num_overshoots_ == 0 ? 0

+ : total_frames / stats_.num_overshoots_));

if (stats_.num_tl0_frames_ > 0) {

RTC_HISTOGRAM_COUNTS_10000("WebRTC.Video.Screenshare.Layer0.Qp",

stats_.tl0_qp_sum_ / stats_.num_tl0_frames_);