Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Unified Diff: webrtc/system_wrappers/include/metrics.h

Issue 1788783002: Add macros for ability to log samples that are added to histograms (RTC_LOGGED_*). (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/video_coding/timing.cc ('k') | webrtc/video/call_stats.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/system_wrappers/include/metrics.h
diff --git a/webrtc/system_wrappers/include/metrics.h b/webrtc/system_wrappers/include/metrics.h
index b0a77c8711a7c33b247f91f7c3750697b108af75..2c04c11bdffd128b84fdfdf52d563b15f915333f 100644
--- a/webrtc/system_wrappers/include/metrics.h
+++ b/webrtc/system_wrappers/include/metrics.h
@@ -15,6 +15,7 @@
#include "webrtc/base/atomicops.h"
#include "webrtc/base/checks.h"
+#include "webrtc/base/logging.h"
#include "webrtc/common_types.h"
// Macros for allowing WebRTC clients (e.g. Chrome) to gather and aggregate
@@ -78,7 +79,27 @@
RTC_HISTOGRAM_COUNTS(name, sample, 1, 100000, 50)
#define RTC_HISTOGRAM_COUNTS(name, sample, min, max, bucket_count) \
- RTC_HISTOGRAM_COMMON_BLOCK(name, sample, \
+ RTC_HISTOGRAM_COMMON_BLOCK(name, sample, false, \
+ webrtc::metrics::HistogramFactoryGetCounts(name, min, max, bucket_count))
+
+// RTC_HISTOGRAM_COUNTS with logging.
+#define RTC_LOGGED_HISTOGRAM_COUNTS_100(name, sample) \
+ RTC_LOGGED_HISTOGRAM_COUNTS(name, sample, 1, 100, 50)
+
+#define RTC_LOGGED_HISTOGRAM_COUNTS_200(name, sample) \
+ RTC_LOGGED_HISTOGRAM_COUNTS(name, sample, 1, 200, 50)
+
+#define RTC_LOGGED_HISTOGRAM_COUNTS_1000(name, sample) \
+ RTC_LOGGED_HISTOGRAM_COUNTS(name, sample, 1, 1000, 50)
+
+#define RTC_LOGGED_HISTOGRAM_COUNTS_10000(name, sample) \
+ RTC_LOGGED_HISTOGRAM_COUNTS(name, sample, 1, 10000, 50)
+
+#define RTC_LOGGED_HISTOGRAM_COUNTS_100000(name, sample) \
+ RTC_LOGGED_HISTOGRAM_COUNTS(name, sample, 1, 100000, 50)
+
+#define RTC_LOGGED_HISTOGRAM_COUNTS(name, sample, min, max, bucket_count) \
+ RTC_HISTOGRAM_COMMON_BLOCK(name, sample, true, \
webrtc::metrics::HistogramFactoryGetCounts(name, min, max, bucket_count))
// Deprecated.
@@ -94,17 +115,29 @@
#define RTC_HISTOGRAM_PERCENTAGE(name, sample) \
RTC_HISTOGRAM_ENUMERATION(name, sample, 101)
+// RTC_HISTOGRAM_PERCENTAGE with logging.
+#define RTC_LOGGED_HISTOGRAM_PERCENTAGE(name, sample) \
+ RTC_LOGGED_HISTOGRAM_ENUMERATION(name, sample, 101)
+
// Histogram for enumerators (evenly spaced buckets).
// |boundary| should be above the max enumerator sample.
#define RTC_HISTOGRAM_ENUMERATION(name, sample, boundary) \
- RTC_HISTOGRAM_COMMON_BLOCK(name, sample, \
+ RTC_HISTOGRAM_COMMON_BLOCK(name, sample, false, \
+ webrtc::metrics::HistogramFactoryGetEnumeration(name, boundary))
+
+// RTC_HISTOGRAM_ENUMERATION with logging.
+#define RTC_LOGGED_HISTOGRAM_ENUMERATION(name, sample, boundary) \
+ RTC_HISTOGRAM_COMMON_BLOCK(name, sample, true, \
webrtc::metrics::HistogramFactoryGetEnumeration(name, boundary))
// The name of the histogram should not vary.
// TODO(asapersson): Consider changing string to const char*.
-#define RTC_HISTOGRAM_COMMON_BLOCK(constant_name, sample, \
+#define RTC_HISTOGRAM_COMMON_BLOCK(constant_name, sample, log, \
factory_get_invocation) \
do { \
+ if (log) { \
+ LOG(LS_INFO) << constant_name << " " << sample; \
+ } \
static webrtc::metrics::Histogram* atomic_histogram_pointer = nullptr; \
webrtc::metrics::Histogram* histogram_pointer = \
rtc::AtomicOps::AcquireLoadPtr(&atomic_histogram_pointer); \
@@ -162,6 +195,35 @@
RTC_HISTOGRAMS_COMMON(index, name, sample, \
RTC_HISTOGRAM_PERCENTAGE(name, sample))
+// RTC_HISTOGRAMS_COUNTS with logging.
+#define RTC_LOGGED_HISTOGRAMS_COUNTS_100(index, name, sample) \
+ RTC_HISTOGRAMS_COMMON(index, name, sample, \
+ RTC_LOGGED_HISTOGRAM_COUNTS(name, sample, 1, 100, 50))
+
+#define RTC_LOGGED_HISTOGRAMS_COUNTS_200(index, name, sample) \
+ RTC_HISTOGRAMS_COMMON(index, name, sample, \
+ RTC_LOGGED_HISTOGRAM_COUNTS(name, sample, 1, 200, 50))
+
+#define RTC_LOGGED_HISTOGRAMS_COUNTS_1000(index, name, sample) \
+ RTC_HISTOGRAMS_COMMON(index, name, sample, \
+ RTC_LOGGED_HISTOGRAM_COUNTS(name, sample, 1, 1000, 50))
+
+#define RTC_LOGGED_HISTOGRAMS_COUNTS_10000(index, name, sample) \
+ RTC_HISTOGRAMS_COMMON(index, name, sample, \
+ RTC_LOGGED_HISTOGRAM_COUNTS(name, sample, 1, 10000, 50))
+
+#define RTC_LOGGED_HISTOGRAMS_COUNTS_100000(index, name, sample) \
+ RTC_HISTOGRAMS_COMMON(index, name, sample, \
+ RTC_LOGGED_HISTOGRAM_COUNTS(name, sample, 1, 100000, 50))
+
+#define RTC_LOGGED_HISTOGRAMS_ENUMERATION(index, name, sample, boundary) \
+ RTC_HISTOGRAMS_COMMON(index, name, sample, \
+ RTC_LOGGED_HISTOGRAM_ENUMERATION(name, sample, boundary))
+
+#define RTC_LOGGED_HISTOGRAMS_PERCENTAGE(index, name, sample) \
+ RTC_HISTOGRAMS_COMMON(index, name, sample, \
+ RTC_LOGGED_HISTOGRAM_PERCENTAGE(name, sample))
+
#define RTC_HISTOGRAMS_COMMON(index, name, sample, macro_invocation) \
do { \
switch (index) { \
« no previous file with comments | « webrtc/modules/video_coding/timing.cc ('k') | webrtc/video/call_stats.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698