Add macros for ability to log samples that are added to histograms (RTC_LOGGED_*).

webrtc/video/send_statistics_proxy.cc

 /*
  *  Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/video/send_statistics_proxy.h"
 
 #include <algorithm>
 #include <cmath>
 #include <map>
+#include <vector>
 
 #include "webrtc/base/checks.h"
 #include "webrtc/base/logging.h"
 #include "webrtc/system_wrappers/include/metrics.h"
 
 namespace webrtc {
 namespace {
 const float kEncodeTimeWeigthFactor = 0.5f;
 
 // Used by histograms. Values of entries should not be changed.
@@ skipping 95 matching lines @@
 void SendStatisticsProxy::UmaSamplesContainer::UpdateHistograms(
     const VideoSendStream::Config& config,
     const VideoSendStream::Stats& current_stats) {
   RTC_DCHECK(uma_prefix_ == kRealtimePrefix || uma_prefix_ == kScreenPrefix);
   const int kIndex = uma_prefix_ == kScreenPrefix ? 1 : 0;
   const int kMinRequiredSamples = 200;
   int in_width = input_width_counter_.Avg(kMinRequiredSamples);
   int in_height = input_height_counter_.Avg(kMinRequiredSamples);
   int in_fps = round(input_frame_rate_tracker_.ComputeTotalRate());
   if (in_width != -1) {
-    RTC_HISTOGRAMS_COUNTS_10000(kIndex, uma_prefix_ + "InputWidthInPixels",
-                                in_width);
-    RTC_HISTOGRAMS_COUNTS_10000(kIndex, uma_prefix_ + "InputHeightInPixels",
-                                in_height);
-    RTC_HISTOGRAMS_COUNTS_100(kIndex, uma_prefix_ + "InputFramesPerSecond",
-                              in_fps);
+    RTC_LOGGED_HISTOGRAMS_COUNTS_10000(
+        kIndex, uma_prefix_ + "InputWidthInPixels", in_width);
+    RTC_LOGGED_HISTOGRAMS_COUNTS_10000(
+        kIndex, uma_prefix_ + "InputHeightInPixels", in_height);
+    RTC_LOGGED_HISTOGRAMS_COUNTS_100(
+        kIndex, uma_prefix_ + "InputFramesPerSecond", in_fps);
   }
   int sent_width = sent_width_counter_.Avg(kMinRequiredSamples);
   int sent_height = sent_height_counter_.Avg(kMinRequiredSamples);
   int sent_fps = round(sent_frame_rate_tracker_.ComputeTotalRate());
   if (sent_width != -1) {
-    RTC_HISTOGRAMS_COUNTS_10000(kIndex, uma_prefix_ + "SentWidthInPixels",
-                                sent_width);
-    RTC_HISTOGRAMS_COUNTS_10000(kIndex, uma_prefix_ + "SentHeightInPixels",
-                                sent_height);
-    RTC_HISTOGRAMS_COUNTS_100(kIndex, uma_prefix_ + "SentFramesPerSecond",
-                              sent_fps);
+    RTC_LOGGED_HISTOGRAMS_COUNTS_10000(
+        kIndex, uma_prefix_ + "SentWidthInPixels", sent_width);
+    RTC_LOGGED_HISTOGRAMS_COUNTS_10000(
+        kIndex, uma_prefix_ + "SentHeightInPixels", sent_height);
+    RTC_LOGGED_HISTOGRAMS_COUNTS_100(
+        kIndex, uma_prefix_ + "SentFramesPerSecond", sent_fps);
   }
   int encode_ms = encode_time_counter_.Avg(kMinRequiredSamples);
   if (encode_ms != -1) {
-    RTC_HISTOGRAMS_COUNTS_1000(kIndex, uma_prefix_ + "EncodeTimeInMs",
-                               encode_ms);
+    RTC_LOGGED_HISTOGRAMS_COUNTS_1000(kIndex, uma_prefix_ + "EncodeTimeInMs",
+                                      encode_ms);
   }
   int key_frames_permille = key_frame_counter_.Permille(kMinRequiredSamples);
   if (key_frames_permille != -1) {
-    RTC_HISTOGRAMS_COUNTS_1000(kIndex, uma_prefix_ + "KeyFramesSentInPermille",
-                               key_frames_permille);
+    RTC_LOGGED_HISTOGRAMS_COUNTS_1000(
+        kIndex, uma_prefix_ + "KeyFramesSentInPermille", key_frames_permille);
   }
   int quality_limited =
       quality_limited_frame_counter_.Percent(kMinRequiredSamples);
   if (quality_limited != -1) {
-    RTC_HISTOGRAMS_PERCENTAGE(kIndex,
-                              uma_prefix_ + "QualityLimitedResolutionInPercent",
-                              quality_limited);
+    RTC_LOGGED_HISTOGRAMS_PERCENTAGE(
+        kIndex, uma_prefix_ + "QualityLimitedResolutionInPercent",
+        quality_limited);
   }
   int downscales = quality_downscales_counter_.Avg(kMinRequiredSamples);
   if (downscales != -1) {
-    RTC_HISTOGRAMS_ENUMERATION(
+    RTC_LOGGED_HISTOGRAMS_ENUMERATION(
         kIndex, uma_prefix_ + "QualityLimitedResolutionDownscales", downscales,
         20);
   }
   int bw_limited = bw_limited_frame_counter_.Percent(kMinRequiredSamples);
   if (bw_limited != -1) {
-    RTC_HISTOGRAMS_PERCENTAGE(
+    RTC_LOGGED_HISTOGRAMS_PERCENTAGE(
         kIndex, uma_prefix_ + "BandwidthLimitedResolutionInPercent",
         bw_limited);
   }
   int num_disabled = bw_resolutions_disabled_counter_.Avg(kMinRequiredSamples);
   if (num_disabled != -1) {
-    RTC_HISTOGRAMS_ENUMERATION(
+    RTC_LOGGED_HISTOGRAMS_ENUMERATION(
         kIndex, uma_prefix_ + "BandwidthLimitedResolutionsDisabled",
         num_disabled, 10);
   }
   int delay_ms = delay_counter_.Avg(kMinRequiredSamples);
   if (delay_ms != -1)
-    RTC_HISTOGRAMS_COUNTS_100000(kIndex, uma_prefix_ + "SendSideDelayInMs",
-                                 delay_ms);
+    RTC_LOGGED_HISTOGRAMS_COUNTS_100000(
+        kIndex, uma_prefix_ + "SendSideDelayInMs", delay_ms);
 
   int max_delay_ms = max_delay_counter_.Avg(kMinRequiredSamples);
   if (max_delay_ms != -1) {
-    RTC_HISTOGRAMS_COUNTS_100000(kIndex, uma_prefix_ + "SendSideDelayMaxInMs",
-                                 max_delay_ms);
+    RTC_LOGGED_HISTOGRAMS_COUNTS_100000(
+        kIndex, uma_prefix_ + "SendSideDelayMaxInMs", max_delay_ms);
   }
 
   if (first_rtcp_stats_time_ms_ != -1) {
     int64_t elapsed_sec =
         (clock_->TimeInMilliseconds() - first_rtcp_stats_time_ms_) / 1000;
     if (elapsed_sec >= metrics::kMinRunTimeInSeconds) {
       int fraction_lost = report_block_stats_.FractionLostInPercent();
       if (fraction_lost != -1) {
-        RTC_HISTOGRAMS_PERCENTAGE(
+        RTC_LOGGED_HISTOGRAMS_PERCENTAGE(
             kIndex, uma_prefix_ + "SentPacketsLostInPercent", fraction_lost);
       }
 
       // The RTCP packet type counters, delivered via the
       // RtcpPacketTypeCounterObserver interface, are aggregates over the entire
       // life of the send stream and are not reset when switching content type.
       // For the purpose of these statistics though, we want new counts when
       // switching since we switch histogram name. On every reset of the
       // UmaSamplesContainer, we save the initial state of the counters, so that
       // we can calculate the delta here and aggregate over all ssrcs.
       RtcpPacketTypeCounter counters;
       for (uint32_t ssrc : config.rtp.ssrcs) {
         auto kv = current_stats.substreams.find(ssrc);
         if (kv == current_stats.substreams.end())
           continue;
 
         RtcpPacketTypeCounter stream_counters =
             kv->second.rtcp_packet_type_counts;
         kv = start_stats_.substreams.find(ssrc);
         if (kv != start_stats_.substreams.end())
           stream_counters.Subtract(kv->second.rtcp_packet_type_counts);
 
         counters.Add(stream_counters);
       }
-      RTC_HISTOGRAMS_COUNTS_10000(kIndex,
-                                  uma_prefix_ + "NackPacketsReceivedPerMinute",
-                                  counters.nack_packets * 60 / elapsed_sec);
-      RTC_HISTOGRAMS_COUNTS_10000(kIndex,
-                                  uma_prefix_ + "FirPacketsReceivedPerMinute",
-                                  counters.fir_packets * 60 / elapsed_sec);
-      RTC_HISTOGRAMS_COUNTS_10000(kIndex,
-                                  uma_prefix_ + "PliPacketsReceivedPerMinute",
-                                  counters.pli_packets * 60 / elapsed_sec);
+      RTC_LOGGED_HISTOGRAMS_COUNTS_10000(
+          kIndex, uma_prefix_ + "NackPacketsReceivedPerMinute",
+          counters.nack_packets * 60 / elapsed_sec);
+      RTC_LOGGED_HISTOGRAMS_COUNTS_10000(
+          kIndex, uma_prefix_ + "FirPacketsReceivedPerMinute",
+          counters.fir_packets * 60 / elapsed_sec);
+      RTC_LOGGED_HISTOGRAMS_COUNTS_10000(
+          kIndex, uma_prefix_ + "PliPacketsReceivedPerMinute",
+          counters.pli_packets * 60 / elapsed_sec);
       if (counters.nack_requests > 0) {
-        RTC_HISTOGRAMS_PERCENTAGE(
+        RTC_LOGGED_HISTOGRAMS_PERCENTAGE(
             kIndex, uma_prefix_ + "UniqueNackRequestsReceivedInPercent",
             counters.UniqueNackRequestsInPercent());
       }
     }
   }
 
   if (first_rtp_stats_time_ms_ != -1) {
     int64_t elapsed_sec =
         (clock_->TimeInMilliseconds() - first_rtp_stats_time_ms_) / 1000;
     if (elapsed_sec >= metrics::kMinRunTimeInSeconds) {
       StreamDataCounters rtp;
       StreamDataCounters rtx;
       AccumulateRtpStats(current_stats, config, &rtp, &rtx);
       StreamDataCounters start_rtp;
       StreamDataCounters start_rtx;
       AccumulateRtpStats(start_stats_, config, &start_rtp, &start_rtx);
       rtp.Subtract(start_rtp);
       rtx.Subtract(start_rtx);
       StreamDataCounters rtp_rtx = rtp;
       rtp_rtx.Add(rtx);
 
-      RTC_HISTOGRAMS_COUNTS_10000(
+      RTC_LOGGED_HISTOGRAMS_COUNTS_10000(
           kIndex, uma_prefix_ + "BitrateSentInKbps",
           static_cast<int>(rtp_rtx.transmitted.TotalBytes() * 8 / elapsed_sec /
                            1000));
-      RTC_HISTOGRAMS_COUNTS_10000(
+      RTC_LOGGED_HISTOGRAMS_COUNTS_10000(
           kIndex, uma_prefix_ + "MediaBitrateSentInKbps",
           static_cast<int>(rtp.MediaPayloadBytes() * 8 / elapsed_sec / 1000));
-      RTC_HISTOGRAMS_COUNTS_10000(
+      RTC_LOGGED_HISTOGRAMS_COUNTS_10000(
           kIndex, uma_prefix_ + "PaddingBitrateSentInKbps",
           static_cast<int>(rtp_rtx.transmitted.padding_bytes * 8 / elapsed_sec /
                            1000));
-      RTC_HISTOGRAMS_COUNTS_10000(
+      RTC_LOGGED_HISTOGRAMS_COUNTS_10000(
           kIndex, uma_prefix_ + "RetransmittedBitrateSentInKbps",
           static_cast<int>(rtp_rtx.retransmitted.TotalBytes() * 8 /
                            elapsed_sec / 1000));
       if (!config.rtp.rtx.ssrcs.empty()) {
-        RTC_HISTOGRAMS_COUNTS_10000(
+        RTC_LOGGED_HISTOGRAMS_COUNTS_10000(
             kIndex, uma_prefix_ + "RtxBitrateSentInKbps",
             static_cast<int>(rtx.transmitted.TotalBytes() * 8 / elapsed_sec /
                              1000));
       }
       if (config.rtp.fec.red_payload_type != -1) {
-        RTC_HISTOGRAMS_COUNTS_10000(kIndex,
-                                    uma_prefix_ + "FecBitrateSentInKbps",
-                                    static_cast<int>(rtp_rtx.fec.TotalBytes() *
-                                                     8 / elapsed_sec / 1000));
+        RTC_LOGGED_HISTOGRAMS_COUNTS_10000(
+            kIndex, uma_prefix_ + "FecBitrateSentInKbps",
+            static_cast<int>(rtp_rtx.fec.TotalBytes() * 8 / elapsed_sec /
+                             1000));
       }
     }
   }
 }
 
 void SendStatisticsProxy::SetContentType(
     VideoEncoderConfig::ContentType content_type) {
   rtc::CritScope lock(&crit_);
   if (content_type_ != content_type) {
     uma_container_->UpdateHistograms(config_, stats_);
@@ skipping 263 matching lines @@
   return Fraction(min_required_samples, 1000.0f);
 }
 
 int SendStatisticsProxy::BoolSampleCounter::Fraction(
     int min_required_samples, float multiplier) const {
   if (num_samples < min_required_samples || num_samples == 0)
     return -1;
   return static_cast<int>((sum * multiplier / num_samples) + 0.5f);
 }
 }  // namespace webrtc