Reland the CL to remove candidates when doing continual gathering

Reland the CL to remove candidates when doing continual gathering
When doing candidate re-gathering in the same ICE generation, signal the remote side to remove its remote candidates.

Fixed the pure virtual method in jsep.h
Original CL: https://codereview.webrtc.org/1648813004

This is required to support the new feature continual gathering, which will benefit the network switch. For clients which are broken by this CL, it is sufficient to add an empty method implementation of PeerConnection.Observer.onIceCandidatesRemoved to get the unchanged behavior. But if the clients would like to support continual gathering, they will need to implement this method by sending the removed candidates to the remote participant and the remote participant calls PeerConnection.removeIceCandidates. 

BUG=
R=glaznev@webrtc.org, pthatcher@webrtc.org

Committed: https://crrev.com/7fb69db670c4ce9beb03fad5586dfbafa0cc302a
Cr-Commit-Position: refs/heads/master@{#11985}

[honghaiz3, 2016-03-11 22:45:48]

honghaiz@webrtc.org changed reviewers:
+ glaznev@webrtc.org, pthatcher@webrtc.org

[honghaiz3, 2016-03-11 22:45:49]

PTAL.

[honghaiz3, 2016-03-11 22:46:11]

Description was changed from

==========
Reland the CL to remove candidates when doing continual gathering

BUG=
==========

to

==========
Reland the CL to remove candidates when doing continual gathering

Fixed the pure virtual method in jsep.h

BUG=
==========

[honghaiz3, 2016-03-11 22:46:35]

The CQ bit was checked by honghaiz@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-11 22:46:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1788703003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1788703003/1

[commit-bot: I haz the power, 2016-03-11 22:48:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 22:48:48]

Dry run: Try jobs failed on following builders:
  linux_baremetal on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_baremetal/builds/...)
  linux_compile_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_compile_dbg/build...)
  linux_ubsan on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan/builds/452)

[honghaiz3, 2016-03-11 23:22:55]

Patchset #1 (id:1) has been deleted

[honghaiz3, 2016-03-11 23:23:02]

The CQ bit was checked by honghaiz@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-11 23:23:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1788703003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1788703003/20001

[honghaiz3, 2016-03-11 23:25:38]

Description was changed from

==========
Reland the CL to remove candidates when doing continual gathering

Fixed the pure virtual method in jsep.h

BUG=
==========

to

==========
Reland the CL to remove candidates when doing continual gathering
When doing candidate re-gathering in the same ICE generation, signal the remote
side to remove its remote candidates.

Fixed the pure virtual method in jsep.h

BUG=
==========

[pthatcher1, 2016-03-12 01:24:14]

lgtm

[AlexG, 2016-03-12 01:49:58]

lgtm

[commit-bot: I haz the power, 2016-03-12 02:19:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-12 02:19:43]

Dry run: Try jobs failed on following builders:
  win_drmemory_light on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_drmemory_light/buil...)

[honghaiz3, 2016-03-14 18:22:03]

The CQ bit was checked by honghaiz@webrtc.org

[commit-bot: I haz the power, 2016-03-14 18:22:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1788703003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1788703003/20001

[honghaiz3, 2016-03-14 18:59:39]

Description was changed from

==========
Reland the CL to remove candidates when doing continual gathering
When doing candidate re-gathering in the same ICE generation, signal the remote
side to remove its remote candidates.

Fixed the pure virtual method in jsep.h

BUG=
==========

to

==========
Reland the CL to remove candidates when doing continual gathering
When doing candidate re-gathering in the same ICE generation, signal the remote
side to remove its remote candidates.

Fixed the pure virtual method in jsep.h

BUG=
R=glaznev@webrtc.org, pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/7fb69db670c4ce9beb03fad55...
==========

[honghaiz3, 2016-03-14 18:59:40]

Committed patchset #1 (id:20001) manually as
7fb69db670c4ce9beb03fad5586dfbafa0cc302a (presubmit successful).

[commit-bot: I haz the power, 2016-03-14 18:59:42]

Description was changed from

==========
Reland the CL to remove candidates when doing continual gathering
When doing candidate re-gathering in the same ICE generation, signal the remote
side to remove its remote candidates.

Fixed the pure virtual method in jsep.h

BUG=
R=glaznev@webrtc.org, pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/7fb69db670c4ce9beb03fad55...
==========

to

==========
Reland the CL to remove candidates when doing continual gathering
When doing candidate re-gathering in the same ICE generation, signal the remote
side to remove its remote candidates.

Fixed the pure virtual method in jsep.h

BUG=
R=glaznev@webrtc.org, pthatcher@webrtc.org

Committed: https://crrev.com/7fb69db670c4ce9beb03fad5586dfbafa0cc302a
Cr-Commit-Position: refs/heads/master@{#11985}
==========

[commit-bot: I haz the power, 2016-03-14 18:59:43]

Patchset 1 (id:??) landed as
https://crrev.com/7fb69db670c4ce9beb03fad5586dfbafa0cc302a
Cr-Commit-Position: refs/heads/master@{#11985}

[kjellander_webrtc, 2016-03-21 12:04:51]

Description was changed from

==========
Reland the CL to remove candidates when doing continual gathering
When doing candidate re-gathering in the same ICE generation, signal the remote
side to remove its remote candidates.

Fixed the pure virtual method in jsep.h

BUG=
R=glaznev@webrtc.org, pthatcher@webrtc.org

Committed: https://crrev.com/7fb69db670c4ce9beb03fad5586dfbafa0cc302a
Cr-Commit-Position: refs/heads/master@{#11985}
==========

to

==========
Reland the CL to remove candidates when doing continual gathering
When doing candidate re-gathering in the same ICE generation, signal the remote
side to remove its remote candidates.

Fixed the pure virtual method in jsep.h
Original CL: https://codereview.webrtc.org/1648813004

BUG=
R=glaznev@webrtc.org, pthatcher@webrtc.org

Committed: https://crrev.com/7fb69db670c4ce9beb03fad5586dfbafa0cc302a
Cr-Commit-Position: refs/heads/master@{#11985}
==========

[kjellander_webrtc, 2016-03-21 12:09:20]

On 2016/03/14 18:59:43, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/7fb69db670c4ce9beb03fad5586dfbafa0cc302a
> Cr-Commit-Position: refs/heads/master@{#11985}

I added a link in the CL description to the original CL (but since it's too late
to get it into the Git commit message - please try to do that next time).
Also: I would prefer some more detail on what's happening. Some of it I could
find out by reading in the previous CL
(https://codereview.webrtc.org/1648813004).

It's not clear to me if this is a bugfix or just added nice-to-have
functionality. Clients implementing the Java interface breaks with this CL and
it would be nice if they could know right away what to do. Would adding an empty
method implementation for PeerConnection.Observer.onIceCandidatesRemoved be
sufficient to get unchanged behavior?

[honghaiz3, 2016-03-21 16:58:48]

On 2016/03/21 12:09:20, kjellander (webrtc) wrote:
> On 2016/03/14 18:59:43, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/7fb69db670c4ce9beb03fad5586dfbafa0cc302a
> > Cr-Commit-Position: refs/heads/master@{#11985}
> 
> I added a link in the CL description to the original CL (but since it's too
late
> to get it into the Git commit message - please try to do that next time).
> Also: I would prefer some more detail on what's happening. Some of it I could
> find out by reading in the previous CL
> (https://codereview.webrtc.org/1648813004).
> 
> It's not clear to me if this is a bugfix or just added nice-to-have
> functionality. Clients implementing the Java interface breaks with this CL and
> it would be nice if they could know right away what to do. Would adding an
empty
> method implementation for PeerConnection.Observer.onIceCandidatesRemoved be
> sufficient to get unchanged behavior?
Thanks for adding the link. I should have done that. 

This is needed for a new functionality for supporting continual gathering, which
is a nice-to-have and important feature for network handover.

Yes, it would be sufficient to get unchanged behavior to add an empty method
like what you said. 
Will update the description.

[honghaiz3, 2016-03-21 17:05:06]

Description was changed from

==========
Reland the CL to remove candidates when doing continual gathering
When doing candidate re-gathering in the same ICE generation, signal the remote
side to remove its remote candidates.

Fixed the pure virtual method in jsep.h
Original CL: https://codereview.webrtc.org/1648813004

BUG=
R=glaznev@webrtc.org, pthatcher@webrtc.org

Committed: https://crrev.com/7fb69db670c4ce9beb03fad5586dfbafa0cc302a
Cr-Commit-Position: refs/heads/master@{#11985}
==========

to

==========
Reland the CL to remove candidates when doing continual gathering
When doing candidate re-gathering in the same ICE generation, signal the remote
side to remove its remote candidates.

Fixed the pure virtual method in jsep.h
Original CL: https://codereview.webrtc.org/1648813004

This is required to support the new feature continual gathering, which will
benefit the network switch. For clients which are broken by this CL, it is
sufficient to add an empty method implementation of
PeerConnection.Observer.onIceCandidatesRemoved to get the unchanged behavior.
But if the clients would like to support continual gathering, they will need to
implement this method by sending the removed candidates to the remote
participant and the remote participant calls PeerConnection.removeIceCandidates.


BUG=
R=glaznev@webrtc.org, pthatcher@webrtc.org

Committed: https://crrev.com/7fb69db670c4ce9beb03fad5586dfbafa0cc302a
Cr-Commit-Position: refs/heads/master@{#11985}
==========