Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2045)

Unified Diff: webrtc/pc/channel.h

Issue 1788583004: Enable setting the maximum bitrate limit in RtpSender. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Removed support for bitrate limits for audio streams; corrected code review issues Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/pc/channel.h
diff --git a/webrtc/pc/channel.h b/webrtc/pc/channel.h
index 60b19f8bbac770eacb1ad979881a61a81ce9b4ba..e657f4750f84ab5e9f6a7f8c6be8a5ba5c6d793f 100644
--- a/webrtc/pc/channel.h
+++ b/webrtc/pc/channel.h
@@ -361,6 +361,8 @@ class VoiceChannel : public BaseChannel {
bool SetOutputVolume(uint32_t ssrc, double volume);
void SetRawAudioSink(uint32_t ssrc,
std::unique_ptr<webrtc::AudioSinkInterface> sink);
+ webrtc::RtpParameters GetRtpParameters(uint32_t ssrc) const;
+ bool SetRtpParameters(uint32_t ssrc, const webrtc::RtpParameters& parameters);
// Get statistics about the current media session.
bool GetStats(VoiceMediaInfo* stats);
@@ -381,6 +383,8 @@ class VoiceChannel : public BaseChannel {
int GetInputLevel_w();
int GetOutputLevel_w();
void GetActiveStreams_w(AudioInfo::StreamList* actives);
+ webrtc::RtpParameters GetRtpParameters_w(uint32_t ssrc) const;
+ bool SetRtpParameters_w(uint32_t ssrc, webrtc::RtpParameters parameters);
private:
// overrides from BaseChannel
@@ -408,6 +412,7 @@ class VoiceChannel : public BaseChannel {
virtual void OnMediaMonitorUpdate(
VoiceMediaChannel* media_channel, const VoiceMediaInfo& info);
void OnAudioMonitorUpdate(AudioMonitor* monitor, const AudioInfo& info);
+ bool ApplySendParameters(const AudioSendParameters& parameters);
static const int kEarlyMediaTimeout = 1000;
MediaEngineInterface* media_engine_;
@@ -452,6 +457,8 @@ class VideoChannel : public BaseChannel {
sigslot::signal2<VideoChannel*, const VideoMediaInfo&> SignalMediaMonitor;
bool SetVideoSend(uint32_t ssrc, bool enable, const VideoOptions* options);
+ webrtc::RtpParameters GetRtpParameters(uint32_t ssrc) const;
+ bool SetRtpParameters(uint32_t ssrc, const webrtc::RtpParameters& parameters);
private:
// overrides from BaseChannel
@@ -464,6 +471,9 @@ class VideoChannel : public BaseChannel {
ContentAction action,
std::string* error_desc);
bool GetStats_w(VideoMediaInfo* stats);
+ webrtc::RtpParameters GetRtpParameters_w(uint32_t ssrc) const;
+ bool SetRtpParameters_w(uint32_t ssrc, webrtc::RtpParameters parameters);
+ bool ApplySendParameters(const VideoSendParameters& parameters);
virtual void OnMessage(rtc::Message* pmsg);
virtual void GetSrtpCryptoSuites(std::vector<int>* crypto_suites) const;

Powered by Google App Engine
This is Rietveld 408576698