webrtc/api/rtpsenderinterface.h - Issue 1788583004: Enable setting the maximum bitrate limit in RtpSender.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/api/rtpsenderinterface.h

Issue 1788583004: Enable setting the maximum bitrate limit in RtpSender. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Removed support for bitrate limits for audio streams; corrected code review issues Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/api/rtpsenderinterface.h

diff --git a/webrtc/api/rtpsenderinterface.h b/webrtc/api/rtpsenderinterface.h

index c3dd52fe16e4cb604ff6fcc33ffdca70164198c8..776d01ace6b4457a960dbcf1795d70e8de11c805 100644

--- a/webrtc/api/rtpsenderinterface.h

+++ b/webrtc/api/rtpsenderinterface.h

@@ -18,6 +18,7 @@

#include "webrtc/api/mediastreaminterface.h"

#include "webrtc/api/proxy.h"

+#include "webrtc/api/rtpparameters.h"

#include "webrtc/base/refcount.h"

#include "webrtc/base/scoped_ref_ptr.h"

#include "webrtc/pc/mediasession.h"

@@ -51,6 +52,9 @@ class RtpSenderInterface : public rtc::RefCountInterface {

virtual void Stop() = 0;

+ virtual RtpParameters GetParameters() const = 0;

+ virtual bool SetParameters(const RtpParameters& parameters) = 0;

protected:

virtual ~RtpSenderInterface() {}

};

@@ -66,6 +70,8 @@ PROXY_CONSTMETHOD0(std::string, id)

PROXY_METHOD1(void, set_stream_id, const std::string&)

PROXY_CONSTMETHOD0(std::string, stream_id)

PROXY_METHOD0(void, Stop)

+PROXY_CONSTMETHOD0(RtpParameters, GetParameters);

+PROXY_METHOD1(bool, SetParameters, const RtpParameters&)

END_PROXY()

} // namespace webrtc

« no previous file with comments | « webrtc/api/rtpsender.cc ('k') | webrtc/api/rtpsenderreceiver_unittest.cc » ('j') | webrtc/media/engine/webrtcvideoengine2.h » ('J')