Enable setting the maximum bitrate limit in RtpSender.

webrtc/api/webrtcsession_unittest.cc

 /*
  *  Copyright 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 3315 matching lines @@
   EXPECT_TRUE(channel->GetOutputVolume(receive_ssrc, &volume));
   EXPECT_EQ(1, volume);
   session_->SetAudioPlayout(receive_ssrc, false);
   EXPECT_TRUE(channel->GetOutputVolume(receive_ssrc, &volume));
   EXPECT_EQ(0, volume);
   session_->SetAudioPlayout(receive_ssrc, true);
   EXPECT_TRUE(channel->GetOutputVolume(receive_ssrc, &volume));
   EXPECT_EQ(1, volume);
 }
 
+TEST_F(WebRtcSessionTest, SetAudioMaxSendBitrate) {
+  Init();
+  SendAudioVideoStream1();
+  CreateAndSetRemoteOfferAndLocalAnswer();
+  cricket::FakeVoiceMediaChannel* channel = media_engine_->GetVoiceChannel(0);
+  ASSERT_TRUE(channel != NULL);
+  uint32_t send_ssrc = channel->send_streams()[0].first_ssrc();
+  EXPECT_EQ(-1, channel->max_bps());
+  webrtc::RTCRtpParameters params = session_->GetAudioRtpParameters(send_ssrc);
+  EXPECT_EQ(1, params.encodings.size());
+  EXPECT_EQ(-1, params.encodings[0].max_bitrate_bps);
+  params.encodings[0].max_bitrate_bps = 1000;
+  EXPECT_TRUE(session_->SetAudioRtpParameters(send_ssrc, params));
+
+  // Verify that the media channel received the new parameters

[Taylor Brandstetter, 2016/03/12 01:57:06]

nit: Add periods at the end of comments like this.

[skvlad, 2016/03/15 21:18:18]

Done.

+  params = channel->GetRtpParameters(send_ssrc);
+  EXPECT_EQ(1, params.encodings.size());
+  EXPECT_EQ(1000, params.encodings[0].max_bitrate_bps);
+
+  // Verify that reading back the parameters returns the same
+  // value as what has been set previously
+  params = session_->GetAudioRtpParameters(send_ssrc);
+  EXPECT_EQ(1, params.encodings.size());
+  EXPECT_EQ(1000, params.encodings[0].max_bitrate_bps);
+
+  // Verify that the global bitrate limit (coming from SDP) has
+  // not been changed
+  EXPECT_EQ(-1, channel->max_bps());
+}
+
 TEST_F(WebRtcSessionTest, SetAudioSend) {
   Init();
   SendAudioVideoStream1();
   CreateAndSetRemoteOfferAndLocalAnswer();
   cricket::FakeVoiceMediaChannel* channel = media_engine_->GetVoiceChannel(0);
   ASSERT_TRUE(channel != NULL);
   ASSERT_EQ(1u, channel->send_streams().size());
   uint32_t send_ssrc = channel->send_streams()[0].first_ssrc();
   EXPECT_FALSE(channel->IsStreamMuted(send_ssrc));
 
@@ skipping 46 matching lines @@
   EXPECT_TRUE(channel->sinks().begin()->second == NULL);
   ASSERT_EQ(1u, channel->recv_streams().size());
   uint32_t receive_ssrc = channel->recv_streams()[0].first_ssrc();
   cricket::FakeVideoRenderer renderer;
   session_->SetVideoPlayout(receive_ssrc, true, &renderer);
   EXPECT_TRUE(channel->sinks().begin()->second == &renderer);
   session_->SetVideoPlayout(receive_ssrc, false, &renderer);
   EXPECT_TRUE(channel->sinks().begin()->second == NULL);
 }
 
+TEST_F(WebRtcSessionTest, SetVideoMaxSendBitrate) {
+  Init();
+  SendAudioVideoStream1();
+  CreateAndSetRemoteOfferAndLocalAnswer();
+  cricket::FakeVideoMediaChannel* channel = media_engine_->GetVideoChannel(0);
+  ASSERT_TRUE(channel != NULL);
+  uint32_t send_ssrc = channel->send_streams()[0].first_ssrc();
+  EXPECT_EQ(-1, channel->max_bps());
+  webrtc::RTCRtpParameters params = session_->GetVideoRtpParameters(send_ssrc);
+  EXPECT_EQ(1, params.encodings.size());
+  EXPECT_EQ(-1, params.encodings[0].max_bitrate_bps);
+  params.encodings[0].max_bitrate_bps = 1000;
+  EXPECT_TRUE(session_->SetVideoRtpParameters(send_ssrc, params));
+
+  // Read back the parameters and verify they have been changed
+  params = session_->GetVideoRtpParameters(send_ssrc);
+  EXPECT_EQ(1, params.encodings.size());
+  EXPECT_EQ(1000, params.encodings[0].max_bitrate_bps);
+
+  // Verify that the video channel received the new parameters
+  params = channel->GetRtpParameters(send_ssrc);
+  EXPECT_EQ(1, params.encodings.size());
+  EXPECT_EQ(1000, params.encodings[0].max_bitrate_bps);
+
+  // Verify that the global bitrate limit has not been changed
+  EXPECT_EQ(-1, channel->max_bps());
+}
+
 TEST_F(WebRtcSessionTest, SetVideoSend) {
   Init();
   SendAudioVideoStream1();
   CreateAndSetRemoteOfferAndLocalAnswer();
   cricket::FakeVideoMediaChannel* channel = media_engine_->GetVideoChannel(0);
   ASSERT_TRUE(channel != NULL);
   ASSERT_EQ(1u, channel->send_streams().size());
   uint32_t send_ssrc = channel->send_streams()[0].first_ssrc();
   EXPECT_FALSE(channel->IsStreamMuted(send_ssrc));
   cricket::VideoOptions* options = NULL;
@@ skipping 919 matching lines @@
 }
 
 // TODO(bemasc): Add a TestIceStatesBundle with BUNDLE enabled.  That test
 // currently fails because upon disconnection and reconnection OnIceComplete is
 // called more than once without returning to IceGatheringGathering.
 
 INSTANTIATE_TEST_CASE_P(WebRtcSessionTests,
                         WebRtcSessionTest,
                         testing::Values(ALREADY_GENERATED,
                                         DTLS_IDENTITY_STORE));