Enable setting the maximum bitrate limit in RtpSender.

webrtc/api/rtpparameters.h

+/*
+ *  Copyright 2015 The WebRTC project authors. All Rights Reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+// This file contains definitions of structures part of the RtpSender interface
+// http://w3c.github.io/webrtc-pc/#rtcrtpsender-interface
+
+#ifndef WEBRTC_API_RTPPARAMETERS_H_
+#define WEBRTC_API_RTPPARAMETERS_H_
+
+#include <vector>
+
+namespace webrtc {

[pthatcher1, 2016/03/12 01:21:03]

FYI, you'll need to make sure you don't break the Chrome build, which has a
different build file.

+
+struct RTCRtpEncodingParameters {

[pthatcher1, 2016/03/12 01:21:03]

Can we please remove the RTC prefix and just call it RtpParameters and
RtpEncodingParameters?

[skvlad, 2016/03/15 21:18:17]

Done.

+  int max_bitrate_bps;
+  RTCRtpEncodingParameters() : max_bitrate_bps(-1) {}

[pthatcher1, 2016/03/12 01:21:03]

You can just do this and not have to define the constructor:

int max_bitrate_bps = -1;

Actually, I think it would make sense to have rtc::Optional here:

rtc::Optional<int> max_bitrate_bps;

[skvlad, 2016/03/15 21:18:17]

Done.
I'll make this change in a separate CL, as it is largely independent of this one
and affects a number of unrelated files.

+};
+
+struct RTCRtpParameters {

[pthatcher1, 2016/03/12 01:21:03]

Can you give a comment pointing the standards doc where these are defined?

[Taylor Brandstetter, 2016/03/12 01:57:06]

It's at the top of the file.

[pthatcher1, 2016/03/14 16:26:50]

Ah, could you (Vlad) move it closer to the classes?  It's a bit hard to see up
there with the license comment.

[skvlad, 2016/03/15 21:18:17]

Done.

+  std::vector<RTCRtpEncodingParameters> encodings;
+
+  static RTCRtpParameters CreateDefault() {

[pthatcher1, 2016/03/12 01:21:03]

Do we really need this in the API?  

[skvlad, 2016/03/15 21:18:17]

Removed.

+    RTCRtpParameters parameters;
+    parameters.encodings.push_back(RTCRtpEncodingParameters());
+    return parameters;
+  }
+};
+
+}  // namespace webrtc
+
+#endif  // WEBRTC_API_RTPPARAMETERS_H_