webrtc/media/engine/webrtcvideoengine2_unittest.cc - Issue 1785713005: Use CopyOnWriteBuffer instead of Buffer to avoid unnecessary copies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/engine/webrtcvideoengine2_unittest.cc

Issue 1785713005: Use CopyOnWriteBuffer instead of Buffer to avoid unnecessary copies. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Feedback from tommi. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/media/engine/webrtcvideoengine2_unittest.cc

diff --git a/webrtc/media/engine/webrtcvideoengine2_unittest.cc b/webrtc/media/engine/webrtcvideoengine2_unittest.cc

index c18f35b5e4e9730b0ca28913549caa2bc2017340..35ec84940522a33b7df541d6caedf585a1600fca 100644

--- a/webrtc/media/engine/webrtcvideoengine2_unittest.cc

+++ b/webrtc/media/engine/webrtcvideoengine2_unittest.cc

@@ -2876,7 +2876,7 @@ TEST_F(WebRtcVideoChannel2Test, DefaultReceiveStreamReconfiguresToUseRtx) {

uint8_t data[kDataLength];

memset(data, 0, sizeof(data));

rtc::SetBE32(&data[8], ssrcs[0]);

- rtc::Buffer packet(data, kDataLength);

+ rtc::CopyOnWriteBuffer packet(data, kDataLength);

rtc::PacketTime packet_time;

channel_->OnPacketReceived(&packet, packet_time);

@@ -3029,7 +3029,7 @@ void WebRtcVideoChannel2Test::TestReceiveUnsignalledSsrcPacket(

rtc::Set8(data, 1, payload_type);

rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);

- rtc::Buffer packet(data, kDataLength);

+ rtc::CopyOnWriteBuffer packet(data, kDataLength);

rtc::PacketTime packet_time;

channel_->OnPacketReceived(&packet, packet_time);

« no previous file with comments | « webrtc/media/engine/webrtcvideoengine2.cc ('k') | webrtc/media/engine/webrtcvoiceengine.h » ('j') | no next file with comments »