webrtc/media/engine/webrtcvideoengine2.h - Issue 1785713005: Use CopyOnWriteBuffer instead of Buffer to avoid unnecessary copies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/engine/webrtcvideoengine2.h

Issue 1785713005: Use CopyOnWriteBuffer instead of Buffer to avoid unnecessary copies. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Feedback from tommi. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/media/engine/webrtcvideoengine2.h

diff --git a/webrtc/media/engine/webrtcvideoengine2.h b/webrtc/media/engine/webrtcvideoengine2.h

index ccf753e9fc663bb6cec50bc7ea364b08df80adbf..3b2cb3f6fee6bed72d23ca76c57d02c5851f897d 100644

--- a/webrtc/media/engine/webrtcvideoengine2.h

+++ b/webrtc/media/engine/webrtcvideoengine2.h

@@ -160,9 +160,9 @@ class WebRtcVideoChannel2 : public VideoMediaChannel, public webrtc::Transport {

bool GetStats(VideoMediaInfo* info) override;

bool SetCapturer(uint32_t ssrc, VideoCapturer* capturer) override;

- void OnPacketReceived(rtc::Buffer* packet,

+ void OnPacketReceived(rtc::CopyOnWriteBuffer* packet,

const rtc::PacketTime& packet_time) override;

- void OnRtcpReceived(rtc::Buffer* packet,

+ void OnRtcpReceived(rtc::CopyOnWriteBuffer* packet,

const rtc::PacketTime& packet_time) override;

void OnReadyToSend(bool ready) override;

void SetInterface(NetworkInterface* iface) override;

« no previous file with comments | « webrtc/media/base/videoengine_unittest.h ('k') | webrtc/media/engine/webrtcvideoengine2.cc » ('j') | no next file with comments »