webrtc/api/webrtcsession.h - Issue 1785713005: Use CopyOnWriteBuffer instead of Buffer to avoid unnecessary copies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/api/webrtcsession.h

Issue 1785713005: Use CopyOnWriteBuffer instead of Buffer to avoid unnecessary copies. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Feedback from tommi. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/api/webrtcsession.h

diff --git a/webrtc/api/webrtcsession.h b/webrtc/api/webrtcsession.h

index 27472c9136ccb1d02fbfa3f10397ccce3d5deb97..07e432661fb93ed99c70cc06bc1d53aa26557c9e 100644

--- a/webrtc/api/webrtcsession.h

+++ b/webrtc/api/webrtcsession.h

@@ -255,7 +255,7 @@ class WebRtcSession : public AudioProviderInterface,

// Implements DataChannelProviderInterface.

bool SendData(const cricket::SendDataParams& params,

- const rtc::Buffer& payload,

+ const rtc::CopyOnWriteBuffer& payload,

cricket::SendDataResult* result) override;

bool ConnectDataChannel(DataChannel* webrtc_data_channel) override;

void DisconnectDataChannel(DataChannel* webrtc_data_channel) override;

@@ -397,7 +397,7 @@ class WebRtcSession : public AudioProviderInterface,

// messages.

void OnDataChannelMessageReceived(cricket::DataChannel* channel,

const cricket::ReceiveDataParams& params,

- const rtc::Buffer& payload);

+ const rtc::CopyOnWriteBuffer& payload);

std::string BadStateErrMsg(State state);

void SetIceConnectionState(PeerConnectionInterface::IceConnectionState state);

« no previous file with comments | « webrtc/api/test/fakedatachannelprovider.h ('k') | webrtc/api/webrtcsession.cc » ('j') | no next file with comments »