Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: webrtc/media/engine/webrtcvideoengine2.h

Issue 1785713005: Use CopyOnWriteBuffer instead of Buffer to avoid unnecessary copies. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Feedback from tommi. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/media/base/videoengine_unittest.h ('k') | webrtc/media/engine/webrtcvideoengine2.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 bool AddSendStream(const StreamParams& sp) override; 153 bool AddSendStream(const StreamParams& sp) override;
154 bool RemoveSendStream(uint32_t ssrc) override; 154 bool RemoveSendStream(uint32_t ssrc) override;
155 bool AddRecvStream(const StreamParams& sp) override; 155 bool AddRecvStream(const StreamParams& sp) override;
156 bool AddRecvStream(const StreamParams& sp, bool default_stream); 156 bool AddRecvStream(const StreamParams& sp, bool default_stream);
157 bool RemoveRecvStream(uint32_t ssrc) override; 157 bool RemoveRecvStream(uint32_t ssrc) override;
158 bool SetSink(uint32_t ssrc, 158 bool SetSink(uint32_t ssrc,
159 rtc::VideoSinkInterface<VideoFrame>* sink) override; 159 rtc::VideoSinkInterface<VideoFrame>* sink) override;
160 bool GetStats(VideoMediaInfo* info) override; 160 bool GetStats(VideoMediaInfo* info) override;
161 bool SetCapturer(uint32_t ssrc, VideoCapturer* capturer) override; 161 bool SetCapturer(uint32_t ssrc, VideoCapturer* capturer) override;
162 162
163 void OnPacketReceived(rtc::Buffer* packet, 163 void OnPacketReceived(rtc::CopyOnWriteBuffer* packet,
164 const rtc::PacketTime& packet_time) override; 164 const rtc::PacketTime& packet_time) override;
165 void OnRtcpReceived(rtc::Buffer* packet, 165 void OnRtcpReceived(rtc::CopyOnWriteBuffer* packet,
166 const rtc::PacketTime& packet_time) override; 166 const rtc::PacketTime& packet_time) override;
167 void OnReadyToSend(bool ready) override; 167 void OnReadyToSend(bool ready) override;
168 void SetInterface(NetworkInterface* iface) override; 168 void SetInterface(NetworkInterface* iface) override;
169 169
170 // Implemented for VideoMediaChannelTest. 170 // Implemented for VideoMediaChannelTest.
171 bool sending() const { return sending_; } 171 bool sending() const { return sending_; }
172 uint32_t GetDefaultSendChannelSsrc() { return default_send_ssrc_; } 172 uint32_t GetDefaultSendChannelSsrc() { return default_send_ssrc_; }
173 173
174 private: 174 private:
175 class WebRtcVideoReceiveStream; 175 class WebRtcVideoReceiveStream;
(...skipping 339 matching lines...) Expand 10 before | Expand all | Expand 10 after
515 webrtc::Call::Config::BitrateConfig bitrate_config_; 515 webrtc::Call::Config::BitrateConfig bitrate_config_;
516 // TODO(deadbeef): Don't duplicate information between 516 // TODO(deadbeef): Don't duplicate information between
517 // send_params/recv_params, rtp_extensions, options, etc. 517 // send_params/recv_params, rtp_extensions, options, etc.
518 VideoSendParameters send_params_; 518 VideoSendParameters send_params_;
519 VideoRecvParameters recv_params_; 519 VideoRecvParameters recv_params_;
520 }; 520 };
521 521
522 } // namespace cricket 522 } // namespace cricket
523 523
524 #endif // WEBRTC_MEDIA_ENGINE_WEBRTCVIDEOENGINE2_H_ 524 #endif // WEBRTC_MEDIA_ENGINE_WEBRTCVIDEOENGINE2_H_
OLDNEW
« no previous file with comments | « webrtc/media/base/videoengine_unittest.h ('k') | webrtc/media/engine/webrtcvideoengine2.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698