Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Side by Side Diff: webrtc/api/webrtcsession_unittest.cc

Issue 1785713005: Use CopyOnWriteBuffer instead of Buffer to avoid unnecessary copies. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Feedback from tommi. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/webrtcsession.cc ('k') | webrtc/base/buffer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 3929 matching lines...) Expand 10 before | Expand all | Expand 10 after
3940 TEST_P(WebRtcSessionTest, TestSctpDataChannelOpenMessage) { 3940 TEST_P(WebRtcSessionTest, TestSctpDataChannelOpenMessage) {
3941 MAYBE_SKIP_TEST(rtc::SSLStreamAdapter::HaveDtlsSrtp); 3941 MAYBE_SKIP_TEST(rtc::SSLStreamAdapter::HaveDtlsSrtp);
3942 3942
3943 InitWithDtls(GetParam()); 3943 InitWithDtls(GetParam());
3944 3944
3945 SetLocalDescriptionWithDataChannel(); 3945 SetLocalDescriptionWithDataChannel();
3946 EXPECT_EQ(cricket::DCT_SCTP, data_engine_->last_channel_type()); 3946 EXPECT_EQ(cricket::DCT_SCTP, data_engine_->last_channel_type());
3947 3947
3948 webrtc::DataChannelInit config; 3948 webrtc::DataChannelInit config;
3949 config.id = 1; 3949 config.id = 1;
3950 rtc::Buffer payload; 3950 rtc::CopyOnWriteBuffer payload;
3951 webrtc::WriteDataChannelOpenMessage("a", config, &payload); 3951 webrtc::WriteDataChannelOpenMessage("a", config, &payload);
3952 cricket::ReceiveDataParams params; 3952 cricket::ReceiveDataParams params;
3953 params.ssrc = config.id; 3953 params.ssrc = config.id;
3954 params.type = cricket::DMT_CONTROL; 3954 params.type = cricket::DMT_CONTROL;
3955 3955
3956 cricket::DataChannel* data_channel = session_->data_channel(); 3956 cricket::DataChannel* data_channel = session_->data_channel();
3957 data_channel->SignalDataReceived(data_channel, params, payload); 3957 data_channel->SignalDataReceived(data_channel, params, payload);
3958 3958
3959 EXPECT_EQ("a", last_data_channel_label_); 3959 EXPECT_EQ("a", last_data_channel_label_);
3960 EXPECT_EQ(config.id, last_data_channel_config_.id); 3960 EXPECT_EQ(config.id, last_data_channel_config_.id);
(...skipping 326 matching lines...) Expand 10 before | Expand all | Expand 10 after
4287 } 4287 }
4288 4288
4289 // TODO(bemasc): Add a TestIceStatesBundle with BUNDLE enabled. That test 4289 // TODO(bemasc): Add a TestIceStatesBundle with BUNDLE enabled. That test
4290 // currently fails because upon disconnection and reconnection OnIceComplete is 4290 // currently fails because upon disconnection and reconnection OnIceComplete is
4291 // called more than once without returning to IceGatheringGathering. 4291 // called more than once without returning to IceGatheringGathering.
4292 4292
4293 INSTANTIATE_TEST_CASE_P(WebRtcSessionTests, 4293 INSTANTIATE_TEST_CASE_P(WebRtcSessionTests,
4294 WebRtcSessionTest, 4294 WebRtcSessionTest,
4295 testing::Values(ALREADY_GENERATED, 4295 testing::Values(ALREADY_GENERATED,
4296 DTLS_IDENTITY_STORE)); 4296 DTLS_IDENTITY_STORE));
OLDNEW
« no previous file with comments | « webrtc/api/webrtcsession.cc ('k') | webrtc/base/buffer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698