Relanding https://codereview.webrtc.org/1715883002/ in pieces.

Relanding https://codereview.webrtc.org/1715883002/ in pieces.

- Clean up unused methods in voe::Channel following removal of VoEDtmf APIs.

BUG=webrtc:4690
Committed: https://crrev.com/b2a24ecf44d039b235d40dbbdf8cfe51d110a029
Cr-Commit-Position: refs/heads/master@{#11976}

[the sun, 2016-03-11 12:18:31]

The CQ bit was checked by solenberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-11 12:18:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1785643006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1785643006/40001

[the sun, 2016-03-11 12:18:39]

solenberg@webrtc.org changed reviewers:
+ tina.legrand@webrtc.org

[commit-bot: I haz the power, 2016-03-11 13:30:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 13:30:25]

Dry run: This issue passed the CQ dry run.

[tlegrand-webrtc, 2016-03-11 13:49:18]

I have a question. Maybe I missed this in the first review?

https://codereview.webrtc.org/1785643006/diff/40001/webrtc/voice_engine/chann...
File webrtc/voice_engine/channel.h (left):

https://codereview.webrtc.org/1785643006/diff/40001/webrtc/voice_engine/chann...
webrtc/voice_engine/channel.h:516: uint8_t _sendTelephoneEventPayloadType;
I wonder if this should remain? It's used for the out of band DTMF tones sent on
a separate payload type, right?

[the sun, 2016-03-11 13:56:24]

https://codereview.webrtc.org/1785643006/diff/40001/webrtc/voice_engine/chann...
File webrtc/voice_engine/channel.h (left):

https://codereview.webrtc.org/1785643006/diff/40001/webrtc/voice_engine/chann...
webrtc/voice_engine/channel.h:516: uint8_t _sendTelephoneEventPayloadType;
On 2016/03/11 13:49:17, tlegrand-webrtc wrote:
> I wonder if this should remain? It's used for the out of band DTMF tones sent
on
> a separate payload type, right?

Correct, but it is only used here to support retrieving the payload type again
(which isn't supported through the new API). The payload type is propagated down
to the RtpRtcpModule where it is also stored for stamping outgoing packets. See
SetSendTelephoneEventPayloadType().

[the sun, 2016-03-11 14:11:14]

The CQ bit was checked by solenberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-11 14:11:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1785643006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1785643006/60001

[commit-bot: I haz the power, 2016-03-11 16:11:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 16:11:57]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[tlegrand-webrtc, 2016-03-14 08:24:50]

lgtm

https://codereview.webrtc.org/1785643006/diff/40001/webrtc/voice_engine/chann...
File webrtc/voice_engine/channel.h (left):

https://codereview.webrtc.org/1785643006/diff/40001/webrtc/voice_engine/chann...
webrtc/voice_engine/channel.h:516: uint8_t _sendTelephoneEventPayloadType;
On 2016/03/11 13:56:24, the sun wrote:
> On 2016/03/11 13:49:17, tlegrand-webrtc wrote:
> > I wonder if this should remain? It's used for the out of band DTMF tones
sent
> on
> > a separate payload type, right?
> 
> Correct, but it is only used here to support retrieving the payload type again
> (which isn't supported through the new API). The payload type is propagated
down
> to the RtpRtcpModule where it is also stored for stamping outgoing packets.
See
> SetSendTelephoneEventPayloadType().

Acknowledged.

[the sun, 2016-03-14 09:15:56]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2016-03-14 09:15:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
tina.legrand@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1785643006/#ps80001 (title:
"rebase")

[commit-bot: I haz the power, 2016-03-14 09:16:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1785643006/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1785643006/80001

[commit-bot: I haz the power, 2016-03-14 10:25:13]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-14 10:25:21]

Description was changed from

==========
Relanding https://codereview.webrtc.org/1715883002/ in pieces.

- Clean up unused methods in voe::Channel following removal of VoEDtmf APIs.

BUG=webrtc:4690
==========

to

==========
Relanding https://codereview.webrtc.org/1715883002/ in pieces.

- Clean up unused methods in voe::Channel following removal of VoEDtmf APIs.

BUG=webrtc:4690

Committed: https://crrev.com/b2a24ecf44d039b235d40dbbdf8cfe51d110a029
Cr-Commit-Position: refs/heads/master@{#11976}
==========

[commit-bot: I haz the power, 2016-03-14 10:25:22]

Patchset 5 (id:??) landed as
https://crrev.com/b2a24ecf44d039b235d40dbbdf8cfe51d110a029
Cr-Commit-Position: refs/heads/master@{#11976}