Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: webrtc/p2p/base/p2ptransportchannel.cc

Issue 1785613011: Revert of Remove candidates when doing continual gathering (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/p2p/base/p2ptransportchannel.h ('k') | webrtc/p2p/base/p2ptransportchannel_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/p2p/base/p2ptransportchannel.cc
diff --git a/webrtc/p2p/base/p2ptransportchannel.cc b/webrtc/p2p/base/p2ptransportchannel.cc
index cdfcf956434723436a355032f3704f53b755de74..b21d584bf8930d0d3acd47a37d4c77649bf3da49 100644
--- a/webrtc/p2p/base/p2ptransportchannel.cc
+++ b/webrtc/p2p/base/p2ptransportchannel.cc
@@ -761,19 +761,6 @@
SortConnections();
}
-void P2PTransportChannel::RemoveRemoteCandidate(
- const Candidate& cand_to_remove) {
- auto iter =
- std::remove_if(remote_candidates_.begin(), remote_candidates_.end(),
- [cand_to_remove](const Candidate& candidate) {
- return cand_to_remove.MatchesForRemoval(candidate);
- });
- if (iter != remote_candidates_.end()) {
- LOG(LS_VERBOSE) << "Removed remote candidate " << cand_to_remove.ToString();
- remote_candidates_.erase(iter, remote_candidates_.end());
- }
-}
-
// Creates connections from all of the ports that we care about to the given
// remote candidate. The return value is true if we created a connection from
// the origin port.
@@ -1462,11 +1449,7 @@
ports_.erase(it);
LOG(INFO) << "Removed port due to inactive networks: " << ports_.size()
<< " remaining";
- std::vector<Candidate> candidates = port->Candidates();
- for (Candidate& candidate : candidates) {
- candidate.set_transport_name(transport_name());
- }
- SignalCandidatesRemoved(this, candidates);
+ // TODO(honghaiz): Signal candidate removals to the remote side.
}
// We data is available, let listeners know
« no previous file with comments | « webrtc/p2p/base/p2ptransportchannel.h ('k') | webrtc/p2p/base/p2ptransportchannel_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698