Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1785353003: Replace scoped_ptr with unique_ptr in talk/ (Closed)

Created:
4 years, 9 months ago by kwiberg-webrtc
Modified:
4 years, 9 months ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace scoped_ptr with unique_ptr in talk/ BUG=webrtc:5520 Committed: https://crrev.com/84cc9189fb53c10def7089c69d345abcec927f00 Cr-Commit-Position: refs/heads/master@{#11968}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -23 lines) Patch
M talk/app/webrtc/objc/RTCAVFoundationVideoSource.mm View 1 chunk +3 lines, -1 line 0 comments Download
M talk/app/webrtc/objc/RTCDataChannel.mm View 3 chunks +4 lines, -3 lines 0 comments Download
M talk/app/webrtc/objc/RTCI420Frame.mm View 1 chunk +3 lines, -2 lines 0 comments Download
M talk/app/webrtc/objc/RTCMediaConstraints.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M talk/app/webrtc/objc/RTCMediaStreamTrack.mm View 2 chunks +3 lines, -1 line 0 comments Download
M talk/app/webrtc/objc/RTCOpenGLVideoRenderer.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M talk/app/webrtc/objc/RTCPeerConnection.mm View 2 chunks +4 lines, -2 lines 0 comments Download
M talk/app/webrtc/objc/RTCPeerConnectionFactory.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M talk/app/webrtc/objc/RTCPeerConnectionFactory+Internal.h View 1 chunk +0 lines, -1 line 0 comments Download
M talk/app/webrtc/objc/RTCPeerConnectionInterface.mm View 2 chunks +5 lines, -2 lines 0 comments Download
M talk/app/webrtc/objc/RTCVideoCapturer.mm View 2 chunks +5 lines, -3 lines 0 comments Download
M talk/app/webrtc/objc/RTCVideoRendererAdapter.mm View 2 chunks +3 lines, -1 line 0 comments Download
M talk/app/webrtc/objc/avfoundationvideocapturer.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
kwiberg-webrtc
4 years, 9 months ago (2016-03-11 15:54:05 UTC) #3
tkchin_webrtc
On 2016/03/11 15:54:05, kwiberg-webrtc wrote: lgtm
4 years, 9 months ago (2016-03-11 17:42:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785353003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785353003/20001
4 years, 9 months ago (2016-03-12 05:15:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 9 months ago (2016-03-12 06:13:00 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-12 06:13:07 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84cc9189fb53c10def7089c69d345abcec927f00
Cr-Commit-Position: refs/heads/master@{#11968}

Powered by Google App Engine
This is Rietveld 408576698