Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1785283002: Move BitrateAllocator reference from ViEEncoder to VideoSendStream. (Closed)

Created:
4 years, 9 months ago by mflodman
Modified:
4 years, 9 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, pbos-webrtc, perkj_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move BitrateAllocator reference from ViEEncoder to VideoSendStream. This CL will be followed up with a CL adding AudioSendStream to BitrateAllocator, so this is a small CL to have the video connection to BitrateAllocator "at the same level" as for audio. BUG=webrtc:5079 R=stefan@webrtc.org Committed: https://crrev.com/86aabb288d61d56955e7fa4890f46f3388f28263 Cr-Commit-Position: refs/heads/master@{#11955}

Patch Set 1 #

Total comments: 8

Patch Set 2 : Comment changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -117 lines) Patch
M webrtc/call/bitrate_allocator.h View 1 4 chunks +25 lines, -15 lines 0 comments Download
M webrtc/call/bitrate_allocator.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M webrtc/call/bitrate_allocator_unittest.cc View 10 chunks +21 lines, -28 lines 0 comments Download
M webrtc/call/call.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/encoder_state_feedback_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/video_send_stream.h View 4 chunks +10 lines, -2 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 7 chunks +20 lines, -5 lines 0 comments Download
M webrtc/video/vie_encoder.h View 5 chunks +2 lines, -15 lines 0 comments Download
M webrtc/video/vie_encoder.cc View 10 chunks +5 lines, -43 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
mflodman
Stefan, Please take a look. It's a quite small CL. https://codereview.webrtc.org/1785283002/diff/1/webrtc/call/bitrate_allocator.h File webrtc/call/bitrate_allocator.h (right): https://codereview.webrtc.org/1785283002/diff/1/webrtc/call/bitrate_allocator.h#newcode28 ...
4 years, 9 months ago (2016-03-11 12:45:03 UTC) #2
stefan-webrtc
https://codereview.webrtc.org/1785283002/diff/1/webrtc/call/bitrate_allocator.h File webrtc/call/bitrate_allocator.h (right): https://codereview.webrtc.org/1785283002/diff/1/webrtc/call/bitrate_allocator.h#newcode10 webrtc/call/bitrate_allocator.h:10: * Usage: this class will register multiple RtcpBitrateObserver's one ...
4 years, 9 months ago (2016-03-11 13:43:54 UTC) #3
mflodman
https://codereview.webrtc.org/1785283002/diff/1/webrtc/call/bitrate_allocator.h File webrtc/call/bitrate_allocator.h (right): https://codereview.webrtc.org/1785283002/diff/1/webrtc/call/bitrate_allocator.h#newcode10 webrtc/call/bitrate_allocator.h:10: * Usage: this class will register multiple RtcpBitrateObserver's one ...
4 years, 9 months ago (2016-03-11 14:26:05 UTC) #4
mflodman
https://codereview.webrtc.org/1785283002/diff/1/webrtc/video/video_send_stream.cc File webrtc/video/video_send_stream.cc (right): https://codereview.webrtc.org/1785283002/diff/1/webrtc/video/video_send_stream.cc#newcode159 webrtc/video/video_send_stream.cc:159: BitrateAllocator* bitrate_allocator, On 2016/03/11 14:26:05, mflodman wrote: > On ...
4 years, 9 months ago (2016-03-11 14:28:39 UTC) #5
stefan-webrtc
lgtm
4 years, 9 months ago (2016-03-11 14:42:30 UTC) #6
mflodman
On 2016/03/11 14:42:30, stefan-webrtc (holmer) wrote: > lgtm Submitting since ps#1 passed all bots and ...
4 years, 9 months ago (2016-03-11 14:43:48 UTC) #7
mflodman
Committed patchset #2 (id:20001) manually as 86aabb288d61d56955e7fa4890f46f3388f28263 (presubmit successful).
4 years, 9 months ago (2016-03-11 14:44:51 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 14:44:52 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/86aabb288d61d56955e7fa4890f46f3388f28263
Cr-Commit-Position: refs/heads/master@{#11955}

Powered by Google App Engine
This is Rietveld 408576698