Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1784323005: Add more conditions for CPU detection in denoiser filter. (Closed)

Created:
4 years, 9 months ago by jackychen_
Modified:
4 years, 9 months ago
Reviewers:
jackychen, marpan2, marpan
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add more conditions for CPU detection in denoiser filter. Add WEBRTC_HAS_NEON and __SSE2__, otherwise, CPU detection fails in some cases. Committed: https://crrev.com/0540242452ef06b1d35ed4843ac6a2355843a56d Cr-Commit-Position: refs/heads/master@{#12001}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M webrtc/modules/video_processing/util/denoiser_filter.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
jackychen_
4 years, 9 months ago (2016-03-14 18:27:44 UTC) #4
marpan
lgtm
4 years, 9 months ago (2016-03-14 18:30:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784323005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784323005/20001
4 years, 9 months ago (2016-03-14 20:47:01 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 9 months ago (2016-03-14 20:47:03 UTC) #10
marpan2
lgtm
4 years, 9 months ago (2016-03-14 20:50:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784323005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784323005/20001
4 years, 9 months ago (2016-03-15 16:58:14 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-15 17:57:32 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 17:57:39 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0540242452ef06b1d35ed4843ac6a2355843a56d
Cr-Commit-Position: refs/heads/master@{#12001}

Powered by Google App Engine
This is Rietveld 408576698