VideoCapturer: Update interface

VideoCapturer: Update interface

This CL changes the interface by adding a SurfaceTextureHelper argument
to VideoCapturer.startCapture(). This removes the need for the
VideoCapturer to create the SurfaceTextureHelper itself. This also means
that it is no longer necessary to send an EGLContext to the
VideoCapturerAndroid.create() function.

The SurfaceTextureHelper is now created in AndroidVideoCapturerJni, and
the EGLContext is passed from PeerConnectionFactory in
nativeCreateVideoSource().

Another change in this CL is that the C++ SurfaceTextureHelper creates
the Java SurfaceTextureHelper instead of getting it passed as an
argument in the ctor.

BUG=webrtc:5519
Committed: https://crrev.com/0dc2316e8b46de179bf766d44afcb3a169430132
Cr-Commit-Position: refs/heads/master@{#11977}

[magjed_webrtc, 2016-03-10 15:21:41]

Description was changed from

==========
VideoCapturer: Update interface

* VideoCapturerAndroid does not need to be created with an EGLContext -
  a SurfaceTexture is passed in startCapture() instead.
  The PeerConnectionFactory passes the local EGLContext in
  nativeCreateVideoSource() to the AndroidVideoCapturerJni ctor, and
  AndroidVideoCapturerJni creates the SurfaceTextureHelper. The
  SurfaceTexture from that SurfaceTextureHelper is then passed in
  startCapture() to the Java VideoCapturer.

* C++ SurfaceTextureHelper creates the Java SurfaceTextureHelper instead
  of getting it passed as an argument in the ctor.

BUG=webrtc:5519
==========

to

==========
VideoCapturer: Update interface

This CL changes the interface by passing the SurfaceTextureHelper in
VideoCapturer.startCapture() which removes the need for the VideoCapturer to
create this object itself. This also means that it's not necessary anymore to
send an EGLContext to the VideoCapturerAndroid.create() function.

The SurfaceTextureHelper is now created in AndroidVideoCapturerJni, and the
EGLContext is passed from PeerConnectionFactory in nativeCreateVideoSource().

Another change in this CL is that the C++ SurfaceTextureHelper creates the Java
SurfaceTextureHelper instead of getting it passed as an argument in the ctor.

BUG=webrtc:5519
==========

[magjed_webrtc, 2016-03-11 14:04:38]

Patchset #2 (id:20001) has been deleted

[magjed_webrtc, 2016-03-11 14:05:41]

Patchset #1 (id:1) has been deleted

[magjed_webrtc, 2016-03-11 14:09:14]

Description was changed from

==========
VideoCapturer: Update interface

This CL changes the interface by passing the SurfaceTextureHelper in
VideoCapturer.startCapture() which removes the need for the VideoCapturer to
create this object itself. This also means that it's not necessary anymore to
send an EGLContext to the VideoCapturerAndroid.create() function.

The SurfaceTextureHelper is now created in AndroidVideoCapturerJni, and the
EGLContext is passed from PeerConnectionFactory in nativeCreateVideoSource().

Another change in this CL is that the C++ SurfaceTextureHelper creates the Java
SurfaceTextureHelper instead of getting it passed as an argument in the ctor.

BUG=webrtc:5519
==========

to

==========
VideoCapturer: Update interface

This CL changes the interface by adding a SurfaceTextureHelper argument
to VideoCapturer.startCapture(). This removes the need for the
VideoCapturer to create the SurfaceTextureHelper itself. This also means
that it is no longer necessary to send an EGLContext to the
VideoCapturerAndroid.create() function.

The SurfaceTextureHelper is now created in AndroidVideoCapturerJni, and
the EGLContext is passed from PeerConnectionFactory in
nativeCreateVideoSource().

Another change in this CL is that the C++ SurfaceTextureHelper creates
the Java SurfaceTextureHelper instead of getting it passed as an
argument in the ctor.

BUG=webrtc:5519
==========

[magjed_webrtc, 2016-03-11 14:09:26]

magjed@webrtc.org changed reviewers:
+ perkj@webrtc.org

[magjed_webrtc, 2016-03-11 14:09:39]

perkj - Please take a look.

[perkj_webrtc, 2016-03-11 15:25:02]

lgtm if the below is addressed.

https://codereview.webrtc.org/1783793002/diff/40001/webrtc/api/androidtests/s...
File webrtc/api/androidtests/src/org/webrtc/VideoCapturerAndroidTest.java
(right):

https://codereview.webrtc.org/1783793002/diff/40001/webrtc/api/androidtests/s...
webrtc/api/androidtests/src/org/webrtc/VideoCapturerAndroidTest.java:92: public
void testStartVideoCapturerUsingTextures() throws InterruptedException {
create a copy of this to test that the current behaviour does not break until
you have fixed existing clients?

https://codereview.webrtc.org/1783793002/diff/40001/webrtc/api/androidtests/s...
File
webrtc/api/androidtests/src/org/webrtc/VideoCapturerAndroidTestFixtures.java
(right):

https://codereview.webrtc.org/1783793002/diff/40001/webrtc/api/androidtests/s...
webrtc/api/androidtests/src/org/webrtc/VideoCapturerAndroidTestFixtures.java:232:
factory.setVideoHwAccelerationOptions(null /* localEglContext */, null /*
remoteEglContext */);
why is this needed?

https://codereview.webrtc.org/1783793002/diff/40001/webrtc/api/androidtests/s...
webrtc/api/androidtests/src/org/webrtc/VideoCapturerAndroidTestFixtures.java:247:
factory.setVideoHwAccelerationOptions(null /* localEglContext */, null /*
remoteEglContext */);
dito?

https://codereview.webrtc.org/1783793002/diff/40001/webrtc/api/java/jni/andro...
File webrtc/api/java/jni/androidvideocapturer_jni.cc (right):

https://codereview.webrtc.org/1783793002/diff/40001/webrtc/api/java/jni/andro...
webrtc/api/java/jni/androidvideocapturer_jni.cc:54:
surface_texture_helper_->GetJavaSurfaceTextureHelper(),
nit: should this be in the other order since you inject the SurfaceHelper to the
VideoCapturer. What if VideoCapturerAndroid.dispose call methods on the
SurfaceHelper?  (not a real problem since VideoCapturerAndroid stop using the
SurfaceTextureHelper? )

https://codereview.webrtc.org/1783793002/diff/40001/webrtc/api/java/jni/surfa...
File webrtc/api/java/jni/surfacetexturehelper_jni.h (right):

https://codereview.webrtc.org/1783793002/diff/40001/webrtc/api/java/jni/surfa...
webrtc/api/java/jni/surfacetexturehelper_jni.h:34: // 1. Create an java instance
of SurfaceTextureHelper.
Please change this comment as well.

[magjed_webrtc, 2016-03-12 15:31:20]

Patchset #2 (id:60001) has been deleted

[magjed_webrtc, 2016-03-13 11:14:34]

https://codereview.webrtc.org/1783793002/diff/40001/webrtc/api/androidtests/s...
File webrtc/api/androidtests/src/org/webrtc/VideoCapturerAndroidTest.java
(right):

https://codereview.webrtc.org/1783793002/diff/40001/webrtc/api/androidtests/s...
webrtc/api/androidtests/src/org/webrtc/VideoCapturerAndroidTest.java:92: public
void testStartVideoCapturerUsingTextures() throws InterruptedException {
On 2016/03/11 15:25:02, perkj_webrtc wrote:
> create a copy of this to test that the current behaviour does not break until
> you have fixed existing clients? 

Done.

https://codereview.webrtc.org/1783793002/diff/40001/webrtc/api/androidtests/s...
File
webrtc/api/androidtests/src/org/webrtc/VideoCapturerAndroidTestFixtures.java
(right):

https://codereview.webrtc.org/1783793002/diff/40001/webrtc/api/androidtests/s...
webrtc/api/androidtests/src/org/webrtc/VideoCapturerAndroidTestFixtures.java:232:
factory.setVideoHwAccelerationOptions(null /* localEglContext */, null /*
remoteEglContext */);
On 2016/03/11 15:25:02, perkj_webrtc wrote:
> why is this needed? 

I wanted to make sure texture capture is enabled, but it turns out this is not
needed. I removed the calls to setVideoHwAccelerationOptions().

https://codereview.webrtc.org/1783793002/diff/40001/webrtc/api/java/jni/andro...
File webrtc/api/java/jni/androidvideocapturer_jni.cc (right):

https://codereview.webrtc.org/1783793002/diff/40001/webrtc/api/java/jni/andro...
webrtc/api/java/jni/androidvideocapturer_jni.cc:54:
surface_texture_helper_->GetJavaSurfaceTextureHelper(),
On 2016/03/11 15:25:02, perkj_webrtc wrote:
> nit: should this be in the other order since you inject the SurfaceHelper to
the
> VideoCapturer. What if VideoCapturerAndroid.dispose call methods on the
> SurfaceHelper?  (not a real problem since VideoCapturerAndroid stop using the
> SurfaceTextureHelper? )

Done, I changed the order.

https://codereview.webrtc.org/1783793002/diff/40001/webrtc/api/java/jni/surfa...
File webrtc/api/java/jni/surfacetexturehelper_jni.h (right):

https://codereview.webrtc.org/1783793002/diff/40001/webrtc/api/java/jni/surfa...
webrtc/api/java/jni/surfacetexturehelper_jni.h:34: // 1. Create an java instance
of SurfaceTextureHelper.
On 2016/03/11 15:25:02, perkj_webrtc wrote:
> Please change this comment as well.

Done.

[magjed_webrtc, 2016-03-14 09:23:59]

The CQ bit was checked by magjed@webrtc.org

[magjed_webrtc, 2016-03-14 09:23:59]

The patchset sent to the CQ was uploaded after l-g-t-m from perkj@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1783793002/#ps80001 (title:
"Addressing perkj@s comments")

[commit-bot: I haz the power, 2016-03-14 09:24:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1783793002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1783793002/80001

[commit-bot: I haz the power, 2016-03-14 10:59:41]

Description was changed from

==========
VideoCapturer: Update interface

This CL changes the interface by adding a SurfaceTextureHelper argument
to VideoCapturer.startCapture(). This removes the need for the
VideoCapturer to create the SurfaceTextureHelper itself. This also means
that it is no longer necessary to send an EGLContext to the
VideoCapturerAndroid.create() function.

The SurfaceTextureHelper is now created in AndroidVideoCapturerJni, and
the EGLContext is passed from PeerConnectionFactory in
nativeCreateVideoSource().

Another change in this CL is that the C++ SurfaceTextureHelper creates
the Java SurfaceTextureHelper instead of getting it passed as an
argument in the ctor.

BUG=webrtc:5519
==========

to

==========
VideoCapturer: Update interface

This CL changes the interface by adding a SurfaceTextureHelper argument
to VideoCapturer.startCapture(). This removes the need for the
VideoCapturer to create the SurfaceTextureHelper itself. This also means
that it is no longer necessary to send an EGLContext to the
VideoCapturerAndroid.create() function.

The SurfaceTextureHelper is now created in AndroidVideoCapturerJni, and
the EGLContext is passed from PeerConnectionFactory in
nativeCreateVideoSource().

Another change in this CL is that the C++ SurfaceTextureHelper creates
the Java SurfaceTextureHelper instead of getting it passed as an
argument in the ctor.

BUG=webrtc:5519
==========

[commit-bot: I haz the power, 2016-03-14 10:59:42]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2016-03-14 10:59:47]

Description was changed from

==========
VideoCapturer: Update interface

This CL changes the interface by adding a SurfaceTextureHelper argument
to VideoCapturer.startCapture(). This removes the need for the
VideoCapturer to create the SurfaceTextureHelper itself. This also means
that it is no longer necessary to send an EGLContext to the
VideoCapturerAndroid.create() function.

The SurfaceTextureHelper is now created in AndroidVideoCapturerJni, and
the EGLContext is passed from PeerConnectionFactory in
nativeCreateVideoSource().

Another change in this CL is that the C++ SurfaceTextureHelper creates
the Java SurfaceTextureHelper instead of getting it passed as an
argument in the ctor.

BUG=webrtc:5519
==========

to

==========
VideoCapturer: Update interface

This CL changes the interface by adding a SurfaceTextureHelper argument
to VideoCapturer.startCapture(). This removes the need for the
VideoCapturer to create the SurfaceTextureHelper itself. This also means
that it is no longer necessary to send an EGLContext to the
VideoCapturerAndroid.create() function.

The SurfaceTextureHelper is now created in AndroidVideoCapturerJni, and
the EGLContext is passed from PeerConnectionFactory in
nativeCreateVideoSource().

Another change in this CL is that the C++ SurfaceTextureHelper creates
the Java SurfaceTextureHelper instead of getting it passed as an
argument in the ctor.

BUG=webrtc:5519

Committed: https://crrev.com/0dc2316e8b46de179bf766d44afcb3a169430132
Cr-Commit-Position: refs/heads/master@{#11977}
==========

[commit-bot: I haz the power, 2016-03-14 10:59:48]

Patchset 2 (id:??) landed as
https://crrev.com/0dc2316e8b46de179bf766d44afcb3a169430132
Cr-Commit-Position: refs/heads/master@{#11977}