Deprecate AudioProcessing::AnalyzeReverseStream(AudioFrame) API

Deprecate AudioProcessing::AnalyzeReverseStream(AudioFrame) API

Committed: https://crrev.com/b031955770f25f9727d5166a3be8d1e118ce6b48
Cr-Commit-Position: refs/heads/master@{#12045}

[aluebs-webrtc, 2016-03-10 20:38:05]

aluebs@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org, peah@webrtc.org, solenberg@webrtc.org,
turaj@webrtc.org

[hlundin-webrtc, 2016-03-11 09:35:50]

lgtm

https://codereview.webrtc.org/1783693005/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/audio_processing_impl_locking_unittest.cc
(right):

https://codereview.webrtc.org/1783693005/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/audio_processing_impl_locking_unittest.cc:38:
AnalyzeReverseStreamImpl1
Does the numeral "1" have any meaning now when there is only one
AnalyzeReverseStreamImpl?

[the sun, 2016-03-11 10:06:24]

lgtm

Great cleanup! One less API, and the APM code is a *little* less entangled. :)

[aluebs-webrtc, 2016-03-11 13:37:55]

https://codereview.webrtc.org/1783693005/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/audio_processing_impl_locking_unittest.cc
(right):

https://codereview.webrtc.org/1783693005/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/audio_processing_impl_locking_unittest.cc:38:
AnalyzeReverseStreamImpl1
On 2016/03/11 09:35:50, hlundin-webrtc wrote:
> Does the numeral "1" have any meaning now when there is only one
> AnalyzeReverseStreamImpl?

Good point. Removed the 1.

[peah-webrtc, 2016-03-11 21:15:06]

On 2016/03/11 13:37:55, aluebs-webrtc wrote:
>
https://codereview.webrtc.org/1783693005/diff/1/webrtc/modules/audio_processi...
> File webrtc/modules/audio_processing/audio_processing_impl_locking_unittest.cc
> (right):
> 
>
https://codereview.webrtc.org/1783693005/diff/1/webrtc/modules/audio_processi...
> webrtc/modules/audio_processing/audio_processing_impl_locking_unittest.cc:38:
> AnalyzeReverseStreamImpl1
> On 2016/03/11 09:35:50, hlundin-webrtc wrote:
> > Does the numeral "1" have any meaning now when there is only one
> > AnalyzeReverseStreamImpl?
> 
> Good point. Removed the 1.

Nice cleanup!
lgtm

[peah-webrtc, 2016-03-11 21:25:51]

https://codereview.webrtc.org/1783693005/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/audio_processing_impl_locking_unittest.cc
(right):

https://codereview.webrtc.org/1783693005/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/audio_processing_impl_locking_unittest.cc:38:
AnalyzeReverseStreamImpl1
On 2016/03/11 09:35:50, hlundin-webrtc wrote:
> Does the numeral "1" have any meaning now when there is only one
> AnalyzeReverseStreamImpl?

No, it does not, please remove that as part of this CL.

[aluebs-webrtc, 2016-03-14 16:42:02]

https://codereview.webrtc.org/1783693005/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/audio_processing_impl_locking_unittest.cc
(right):

https://codereview.webrtc.org/1783693005/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/audio_processing_impl_locking_unittest.cc:38:
AnalyzeReverseStreamImpl1
On 2016/03/11 21:25:50, peah-webrtc wrote:
> On 2016/03/11 09:35:50, hlundin-webrtc wrote:
> > Does the numeral "1" have any meaning now when there is only one
> > AnalyzeReverseStreamImpl?
> 
> No, it does not, please remove that as part of this CL.

Already did.

[peah-webrtc, 2016-03-15 15:22:44]

On 2016/03/14 16:42:02, aluebs-webrtc wrote:
>
https://codereview.webrtc.org/1783693005/diff/1/webrtc/modules/audio_processi...
> File webrtc/modules/audio_processing/audio_processing_impl_locking_unittest.cc
> (right):
> 
>
https://codereview.webrtc.org/1783693005/diff/1/webrtc/modules/audio_processi...
> webrtc/modules/audio_processing/audio_processing_impl_locking_unittest.cc:38:
> AnalyzeReverseStreamImpl1
> On 2016/03/11 21:25:50, peah-webrtc wrote:
> > On 2016/03/11 09:35:50, hlundin-webrtc wrote:
> > > Does the numeral "1" have any meaning now when there is only one
> > > AnalyzeReverseStreamImpl?
> > 
> > No, it does not, please remove that as part of this CL.
> 
> Already did.

Awesome :-)

[aluebs-webrtc, 2016-03-18 02:09:33]

The CQ bit was checked by aluebs@webrtc.org

[aluebs-webrtc, 2016-03-18 02:09:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
solenberg@webrtc.org, henrik.lundin@webrtc.org, peah@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1783693005/#ps40001 (title:
"Rebasing")

[commit-bot: I haz the power, 2016-03-18 02:09:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1783693005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1783693005/40001

[commit-bot: I haz the power, 2016-03-18 03:39:57]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-18 03:40:04]

Description was changed from

==========
Deprecate AudioProcessing::AnalyzeReverseStream(AudioFrame) API
==========

to

==========
Deprecate AudioProcessing::AnalyzeReverseStream(AudioFrame) API

Committed: https://crrev.com/b031955770f25f9727d5166a3be8d1e118ce6b48
Cr-Commit-Position: refs/heads/master@{#12045}
==========

[commit-bot: I haz the power, 2016-03-18 03:40:05]

Patchset 3 (id:??) landed as
https://crrev.com/b031955770f25f9727d5166a3be8d1e118ce6b48
Cr-Commit-Position: refs/heads/master@{#12045}