Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1783263002: Replace scoped_ptr with unique_ptr in webrtc/pc/ (Closed)

Created:
4 years, 9 months ago by kwiberg-webrtc
Modified:
4 years, 9 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace scoped_ptr with unique_ptr in webrtc/pc/ BUG=webrtc:5520 Committed: https://crrev.com/3102294fc0dcccb3aad1e9fd7104a4ba2191c7cb Cr-Commit-Position: refs/heads/master@{#11961}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -206 lines) Patch
M webrtc/api/webrtcsession.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/pc/channel.h View 6 chunks +7 lines, -6 lines 0 comments Download
M webrtc/pc/channel.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M webrtc/pc/channel_unittest.cc View 8 chunks +14 lines, -12 lines 0 comments Download
M webrtc/pc/channelmanager.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/pc/mediasession.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/pc/mediasession.cc View 13 chunks +13 lines, -14 lines 0 comments Download
M webrtc/pc/mediasession_unittest.cc View 71 chunks +102 lines, -113 lines 0 comments Download
M webrtc/pc/planarfunctions_unittest.cc View 18 chunks +39 lines, -39 lines 0 comments Download
M webrtc/pc/srtpfilter.h View 3 chunks +6 lines, -6 lines 0 comments Download
M webrtc/pc/yuvscaler_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kwiberg-webrtc
4 years, 9 months ago (2016-03-11 15:05:10 UTC) #2
tommi
lgtm
4 years, 9 months ago (2016-03-11 22:16:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783263002/1
4 years, 9 months ago (2016-03-11 22:16:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 22:18:24 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 22:18:34 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3102294fc0dcccb3aad1e9fd7104a4ba2191c7cb
Cr-Commit-Position: refs/heads/master@{#11961}

Powered by Google App Engine
This is Rietveld 408576698