Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1782803002: Fix NetEq performance test regression (Closed)

Created:
4 years, 9 months ago by hlundin-webrtc
Modified:
4 years, 9 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix NetEq performance test regression The test code created an AudioBuffer object inside the work loop. This turned out to be expensive, since the AudioBuffer ctor implicitly called memset on all of the audio data array. The obvious remedy is to create the buffer outside of the loop. This does not have any impact apart from the performance boost, since the output data from NetEq is not even considered in the test. BUG=chromium:592907, webrtc:5647 TBR=ivoc@webrtc.org NOTRY=true Committed: https://crrev.com/d72595eeea4812f33bc7e23ec4c2bfcc99adac2f Cr-Commit-Position: refs/heads/master@{#11940}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M webrtc/modules/audio_coding/neteq/tools/neteq_performance_test.cc View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/modules/include/module_common_types.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782803002/1
4 years, 9 months ago (2016-03-10 10:24:57 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 10:26:33 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 10:26:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d72595eeea4812f33bc7e23ec4c2bfcc99adac2f
Cr-Commit-Position: refs/heads/master@{#11940}

Powered by Google App Engine
This is Rietveld 408576698