Fix lock behavior on RTCAudioSession.

Fix lock behavior on RTCAudioSession.

In addition:
- Introduces RTCAudioSessionTest
- iOS/Mac gtests now have an autoreleasepool
- Moves ScopedAutoreleasePool to rtc_base_approved
- Introduces route change button in AppRTCDemo

BUG=webrtc:5649
Committed: https://crrev.com/0ce3bf9cc4d7b8acb4b61556840756504e11f8a4
Cr-Commit-Position: refs/heads/master@{#11971}

[tkchin_webrtc, 2016-03-11 02:46:47]

Description was changed from

==========
Fix lock behavior on RTCAudioSession.

BUG=webrtc:5649
==========

to

==========
Fix lock behavior on RTCAudioSession.

BUG=webrtc:5649
==========

[tkchin_webrtc, 2016-03-11 02:46:48]

tkchin@webrtc.org changed reviewers:
+ haysc@webrtc.org, henrika@webrtc.org, kjellander@webrtc.org

[tkchin_webrtc, 2016-03-11 02:53:09]

Patchset #1 (id:1) has been deleted

[tkchin_webrtc, 2016-03-11 03:02:22]

Patchset #1 (id:20001) has been deleted

[tkchin_webrtc, 2016-03-11 03:03:53]

Description was changed from

==========
Fix lock behavior on RTCAudioSession.

BUG=webrtc:5649
==========

to

==========
Fix lock behavior on RTCAudioSession.

In addition:
- Introduces RTCAudioSessionTest
- iOS/Mac gtests now have an autoreleasepool
- Moves ScopedAutoreleasePool to rtc_base_approved 

BUG=webrtc:5649
==========

[tkchin_webrtc, 2016-03-11 03:04:18]

Description was changed from

==========
Fix lock behavior on RTCAudioSession.

In addition:
- Introduces RTCAudioSessionTest
- iOS/Mac gtests now have an autoreleasepool
- Moves ScopedAutoreleasePool to rtc_base_approved 

BUG=webrtc:5649
==========

to

==========
Fix lock behavior on RTCAudioSession.

In addition:
- Introduces RTCAudioSessionTest
- iOS/Mac gtests now have an autoreleasepool
- Moves ScopedAutoreleasePool to rtc_base_approved
- Introduces route change button in AppRTCDemo

BUG=webrtc:5649
==========

[tkchin_webrtc, 2016-03-11 03:15:05]

Patchset #2 (id:60001) has been deleted

[tkchin_webrtc, 2016-03-11 03:15:14]

Patchset #1 (id:40001) has been deleted

[tkchin_webrtc, 2016-03-11 03:32:29]

@kjellander: is there something wrong with win bots?

[kjellander_webrtc, 2016-03-11 04:44:21]

On 2016/03/11 03:32:29, tkchin_webrtc wrote:
> @kjellander: is there something wrong with win bots?

Yes, infra pushed a bad change, please just retry since it's now been reverted.

[henrika_webrtc, 2016-03-11 09:25:17]

Great work as always. Any other tests you could add now when RTCAudioSessionTest
exists?

LGTM

https://codereview.webrtc.org/1782363002/diff/100001/webrtc/examples/objc/App...
File webrtc/examples/objc/AppRTCDemo/ios/ARDVideoCallViewController.m (right):

https://codereview.webrtc.org/1782363002/diff/100001/webrtc/examples/objc/App...
webrtc/examples/objc/AppRTCDemo/ios/ARDVideoCallViewController.m:134: if
([session overrideOutputAudioPort:override error:&error]) {
FYI,
https://developer.apple.com/library/ios/documentation/AVFoundation/Reference/...:

Apple recommends using the MPVolumeView class to provide user control for audio
input and output selection.

[Chuck, 2016-03-11 16:53:22]

lgtm

https://codereview.webrtc.org/1782363002/diff/100001/webrtc/base/objc/RTCDisp...
File webrtc/base/objc/RTCDispatcher.m (right):

https://codereview.webrtc.org/1782363002/diff/100001/webrtc/base/objc/RTCDisp...
webrtc/base/objc/RTCDispatcher.m:18: dispatch_queue_t _audioSessionQueue;
Are these actually used for anything?

[tkchin_webrtc, 2016-03-11 17:48:21]

@kjellander can you look at the test change when you get a chance? Thanks.

https://codereview.webrtc.org/1782363002/diff/100001/webrtc/base/objc/RTCDisp...
File webrtc/base/objc/RTCDispatcher.m (right):

https://codereview.webrtc.org/1782363002/diff/100001/webrtc/base/objc/RTCDisp...
webrtc/base/objc/RTCDispatcher.m:18: dispatch_queue_t _audioSessionQueue;
On 2016/03/11 16:53:22, Chuck wrote:
> Are these actually used for anything?

lol. Removed, thanks.

https://codereview.webrtc.org/1782363002/diff/100001/webrtc/examples/objc/App...
File webrtc/examples/objc/AppRTCDemo/ios/ARDVideoCallViewController.m (right):

https://codereview.webrtc.org/1782363002/diff/100001/webrtc/examples/objc/App...
webrtc/examples/objc/AppRTCDemo/ios/ARDVideoCallViewController.m:134: if
([session overrideOutputAudioPort:override error:&error]) {
On 2016/03/11 09:25:17, henrika_webrtc wrote:
> FYI,
>
https://developer.apple.com/library/ios/documentation/AVFoundation/Reference/...:
> 
> Apple recommends using the MPVolumeView class to provide user control for
audio
> input and output selection.

Yeah, let's replace it after. I just wanted this one so we could try to repro
the bug.

[Chuck, 2016-03-11 21:35:21]

lgtm

[tkchin_webrtc, 2016-03-12 01:32:25]

Landing this sans the autoreleasepool changes to unblock my other CL. I'll put
that one out separately later.

[tkchin_webrtc, 2016-03-13 00:48:03]

The CQ bit was checked by tkchin@webrtc.org

[tkchin_webrtc, 2016-03-13 00:48:03]

The patchset sent to the CQ was uploaded after l-g-t-m from henrika@webrtc.org,
haysc@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1782363002/#ps140001 (title:
"Remove autoreleasepool bits")

[commit-bot: I haz the power, 2016-03-13 00:48:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1782363002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1782363002/140001

[commit-bot: I haz the power, 2016-03-13 00:52:08]

Description was changed from

==========
Fix lock behavior on RTCAudioSession.

In addition:
- Introduces RTCAudioSessionTest
- iOS/Mac gtests now have an autoreleasepool
- Moves ScopedAutoreleasePool to rtc_base_approved
- Introduces route change button in AppRTCDemo

BUG=webrtc:5649
==========

to

==========
Fix lock behavior on RTCAudioSession.

In addition:
- Introduces RTCAudioSessionTest
- iOS/Mac gtests now have an autoreleasepool
- Moves ScopedAutoreleasePool to rtc_base_approved
- Introduces route change button in AppRTCDemo

BUG=webrtc:5649
==========

[commit-bot: I haz the power, 2016-03-13 00:52:09]

Committed patchset #4 (id:140001)

[commit-bot: I haz the power, 2016-03-13 00:52:19]

Description was changed from

==========
Fix lock behavior on RTCAudioSession.

In addition:
- Introduces RTCAudioSessionTest
- iOS/Mac gtests now have an autoreleasepool
- Moves ScopedAutoreleasePool to rtc_base_approved
- Introduces route change button in AppRTCDemo

BUG=webrtc:5649
==========

to

==========
Fix lock behavior on RTCAudioSession.

In addition:
- Introduces RTCAudioSessionTest
- iOS/Mac gtests now have an autoreleasepool
- Moves ScopedAutoreleasePool to rtc_base_approved
- Introduces route change button in AppRTCDemo

BUG=webrtc:5649

Committed: https://crrev.com/0ce3bf9cc4d7b8acb4b61556840756504e11f8a4
Cr-Commit-Position: refs/heads/master@{#11971}
==========

[commit-bot: I haz the power, 2016-03-13 00:52:22]

Patchset 4 (id:??) landed as
https://crrev.com/0ce3bf9cc4d7b8acb4b61556840756504e11f8a4
Cr-Commit-Position: refs/heads/master@{#11971}