Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1782053002: Relanding https://codereview.webrtc.org/1715883002/ in pieces. (Closed)

Created:
4 years, 9 months ago by the sun
Modified:
4 years, 9 months ago
Reviewers:
tlegrand-webrtc
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, danilchap, yujie_mao (webrtc), zhuangzesen_agora.io, Andrew MacDonald, henrika_webrtc, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Relanding https://codereview.webrtc.org/1715883002/ in pieces. - Use better types in AudioSendStream::SendTelephoneEvent() and related methods. BUG=webrtc:4690 Committed: https://crrev.com/8842c3e41bcc4a2968d7c299f84f87099485a8e8 Cr-Commit-Position: refs/heads/master@{#11953}

Patch Set 1 #

Patch Set 2 : DCHECKs #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -37 lines) Patch
M webrtc/audio/audio_send_stream.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/audio/audio_send_stream.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/audio/audio_send_stream_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/audio_send_stream.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/media/engine/fakewebrtccall.h View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/media/engine/fakewebrtccall.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api_audio.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/mock_voe_channel_proxy.h View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/voice_engine/channel.h View 1 chunk +1 line, -4 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 1 2 chunks +11 lines, -9 lines 0 comments Download
M webrtc/voice_engine/channel_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/channel_proxy.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M webrtc/voice_engine/dtmf_inband.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
the sun
4 years, 9 months ago (2016-03-10 12:09:31 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782053002/20001
4 years, 9 months ago (2016-03-10 12:15:33 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-10 13:46:36 UTC) #6
tlegrand-webrtc
Nice and clean. Thanks! LGTM
4 years, 9 months ago (2016-03-11 09:14:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782053002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782053002/40001
4 years, 9 months ago (2016-03-11 09:53:59 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-11 11:06:46 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 11:06:54 UTC) #13
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/8842c3e41bcc4a2968d7c299f84f87099485a8e8
Cr-Commit-Position: refs/heads/master@{#11953}

Powered by Google App Engine
This is Rietveld 408576698