Tune BWE to be a bit less sensitive to spurious delay events.

Tune BWE to be a bit less sensitive to spurious delay events.

Also fixes a bug where the over-use detector threshold can increase to
its max if there has been a long time between two packets.

BUG=webrtc:5646
Committed: https://crrev.com/1069cac518d1accb782bcc15c9f0c797b69f0ebb
Cr-Commit-Position: refs/heads/master@{#11942}

[stefan-webrtc, 2016-03-10 11:28:44]

stefan@webrtc.org changed reviewers:
+ mflodman@webrtc.org

[stefan-webrtc, 2016-03-10 11:34:41]

https://codereview.webrtc.org/1782003003/diff/1/webrtc/modules/remote_bitrate...
File webrtc/modules/remote_bitrate_estimator/overuse_detector.cc (right):

https://codereview.webrtc.org/1782003003/diff/1/webrtc/modules/remote_bitrate...
webrtc/modules/remote_bitrate_estimator/overuse_detector.cc:145: const int64_t
kMaxTimeDeltaMs = 100;
This was caught by the existing tests:
TestShortTimeoutAndWrap
TestLongTimeoutAndWrap

They didn't catch it previously because they ran for too long after the timeout
so that the (quicker) filter caught up. Reduced the run time after the timeout
so that we are sure to catch regressions.

[stefan-webrtc, 2016-03-10 11:34:47]

The CQ bit was checked by stefan@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-10 11:34:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1782003003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1782003003/1

[mflodman, 2016-03-10 11:59:33]

lgtm

https://codereview.webrtc.org/1782003003/diff/1/webrtc/modules/remote_bitrate...
File webrtc/modules/remote_bitrate_estimator/overuse_detector.cc (right):

https://codereview.webrtc.org/1782003003/diff/1/webrtc/modules/remote_bitrate...
webrtc/modules/remote_bitrate_estimator/overuse_detector.cc:145: const int64_t
kMaxTimeDeltaMs = 100;
On 2016/03/10 11:34:41, stefan-webrtc (holmer) wrote:
> This was caught by the existing tests:
> TestShortTimeoutAndWrap
> TestLongTimeoutAndWrap
> 
> They didn't catch it previously because they ran for too long after the
timeout
> so that the (quicker) filter caught up. Reduced the run time after the timeout
> so that we are sure to catch regressions.

Good catch!

https://codereview.webrtc.org/1782003003/diff/1/webrtc/modules/remote_bitrate...
webrtc/modules/remote_bitrate_estimator/overuse_detector.cc:145: const int64_t
kMaxTimeDeltaMs = 100;
After discussions, I agree that 100 is a good threshold to start with and we can
experiment with higher values later. This will rather err on the pre-fairness
behavior and would be a safer step to take.

[stefan-webrtc, 2016-03-10 12:43:27]

Description was changed from

==========
Tune BWE to be a bit less sensitive to spurious delay events.

Also fixes a bug where the over-use detector threshold can increase to
its max if there has been a long time between two packets.

BUG=5646
==========

to

==========
Tune BWE to be a bit less sensitive to spurious delay events.

Also fixes a bug where the over-use detector threshold can increase to
its max if there has been a long time between two packets.

BUG=webrtc:5646
==========

[commit-bot: I haz the power, 2016-03-10 13:11:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 13:11:29]

Dry run: This issue passed the CQ dry run.

[stefan-webrtc, 2016-03-10 13:11:41]

The CQ bit was checked by stefan@webrtc.org

[commit-bot: I haz the power, 2016-03-10 13:11:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1782003003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1782003003/1

[commit-bot: I haz the power, 2016-03-10 13:13:25]

Description was changed from

==========
Tune BWE to be a bit less sensitive to spurious delay events.

Also fixes a bug where the over-use detector threshold can increase to
its max if there has been a long time between two packets.

BUG=webrtc:5646
==========

to

==========
Tune BWE to be a bit less sensitive to spurious delay events.

Also fixes a bug where the over-use detector threshold can increase to
its max if there has been a long time between two packets.

BUG=webrtc:5646
==========

[commit-bot: I haz the power, 2016-03-10 13:13:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-10 13:13:31]

Description was changed from

==========
Tune BWE to be a bit less sensitive to spurious delay events.

Also fixes a bug where the over-use detector threshold can increase to
its max if there has been a long time between two packets.

BUG=webrtc:5646
==========

to

==========
Tune BWE to be a bit less sensitive to spurious delay events.

Also fixes a bug where the over-use detector threshold can increase to
its max if there has been a long time between two packets.

BUG=webrtc:5646

Committed: https://crrev.com/1069cac518d1accb782bcc15c9f0c797b69f0ebb
Cr-Commit-Position: refs/heads/master@{#11942}
==========

[commit-bot: I haz the power, 2016-03-10 13:13:32]

Patchset 1 (id:??) landed as
https://crrev.com/1069cac518d1accb782bcc15c9f0c797b69f0ebb
Cr-Commit-Position: refs/heads/master@{#11942}