Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1781893002: Revert of Drop the 16kHz sample rate restriction on AECM and zero out higher bands (Closed)

Created:
4 years, 9 months ago by perkj_webrtc
Modified:
4 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, henrika_webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Drop the 16kHz sample rate restriction on AECM and zero out higher bands (patchset #3 id:40001 of https://codereview.webrtc.org/1774553002/ ) Reason for revert: Breaks Android it looks like. See your own try jobs and https://build.chromium.org/p/client.webrtc/builders/Android32%20Tests%20%28L%... Original issue's description: > Drop the 16kHz sample rate restriction on AECM and zero out higher bands > > The restriction has been removed completely and AECM now supports any > number of higher bands. But this has been achieved by always zeroing out the > higher bands, instead of applying a constant gain which is the average over half > of the lower band (like it is done for the AEC), because that would be > non-trivial to implement and we don't want to spend too much time on AECM, since > we want to get rid of it in the long term anyway. > > R=peah@webrtc.org, solenberg@webrtc.org, tina.legrand@webrtc.org > > Committed: https://crrev.com/f687d53aabee0523ce6e9e0636163af8df120e41 > Cr-Commit-Position: refs/heads/master@{#11931} TBR=peah@webrtc.org,turaj@webrtc.org,tina.legrand@webrtc.org,solenberg@webrtc.org,aluebs@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/dfc28703807407fad3fc4f6586ca787c21474443 Cr-Commit-Position: refs/heads/master@{#11932}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -43 lines) Patch
M data/audio_processing/output_data_fixed.pb View Binary file 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.cc View 4 chunks +13 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/echo_control_mobile_impl.cc View 3 chunks +3 lines, -9 lines 0 comments Download
M webrtc/modules/audio_processing/include/audio_processing.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_processing/test/audio_processing_unittest.cc View 10 chunks +53 lines, -33 lines 0 comments Download
M webrtc/voice_engine/transmit_mixer.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
perkj_webrtc
Created Revert of Drop the 16kHz sample rate restriction on AECM and zero out higher ...
4 years, 9 months ago (2016-03-10 00:23:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1781893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1781893002/1
4 years, 9 months ago (2016-03-10 00:23:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 00:23:27 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/dfc28703807407fad3fc4f6586ca787c21474443 Cr-Commit-Position: refs/heads/master@{#11932}
4 years, 9 months ago (2016-03-10 00:23:40 UTC) #6
aluebs-webrtc
4 years, 9 months ago (2016-03-10 08:46:38 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698