Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1780543003: Add tracing to interesting media-related methods. (Closed)

Created:
4 years, 9 months ago by pbos-webrtc
Modified:
4 years, 9 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add tracing to interesting media-related methods. Accounts for a lot of worker-thread blocking by voice-related code or initializing SRTP. BUG= R=pthatcher@webrtc.org Committed: https://crrev.com/ca8b404e86a8482a1bfb2e4bdf8149f8fa197a5a Cr-Commit-Position: refs/heads/master@{#11920}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M webrtc/media/engine/webrtcvideoengine2.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.cc View 10 chunks +10 lines, -0 lines 0 comments Download
M webrtc/pc/channel.cc View 5 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pbos-webrtc
PTAL
4 years, 9 months ago (2016-03-08 22:19:38 UTC) #1
pthatcher1
lgtm
4 years, 9 months ago (2016-03-08 22:21:49 UTC) #2
pbos-webrtc
Committed patchset #1 (id:1) manually as ca8b404e86a8482a1bfb2e4bdf8149f8fa197a5a (presubmit successful).
4 years, 9 months ago (2016-03-08 22:24:27 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 22:24:29 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca8b404e86a8482a1bfb2e4bdf8149f8fa197a5a
Cr-Commit-Position: refs/heads/master@{#11920}

Powered by Google App Engine
This is Rietveld 408576698