Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1780183005: Android: Add more info for createPbufferSurface() exceptions (Closed)

Created:
4 years, 9 months ago by magjed_webrtc
Modified:
4 years, 9 months ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android: Add more info for createPbufferSurface() exceptions This CL adds the width and height to the createPbufferSurface exception message. Also, when a Callable.call() fails in ThreadUtils.invokeUninterruptibly() we rethrow a new exception, but that excludes the callstack from Callable.call(). This CL adds the callstack from Callable.call() to make debugging easier. BUG=b/27581640,b/27516991 Committed: https://crrev.com/80c2cd973de7f3854451bde7bcefb564163bbd74 Cr-Commit-Position: refs/heads/master@{#11996}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M webrtc/api/java/android/org/webrtc/EglBase10.java View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/api/java/android/org/webrtc/EglBase14.java View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/api/java/android/org/webrtc/ThreadUtils.java View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
magjed_webrtc
Alex - Please take a look.
4 years, 9 months ago (2016-03-12 13:03:18 UTC) #4
AlexG
lgtm
4 years, 9 months ago (2016-03-14 16:51:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780183005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780183005/1
4 years, 9 months ago (2016-03-15 09:34:06 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-15 11:43:14 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 11:43:19 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/80c2cd973de7f3854451bde7bcefb564163bbd74
Cr-Commit-Position: refs/heads/master@{#11996}

Powered by Google App Engine
This is Rietveld 408576698