Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1779883004: Change VideoCapture_apply_rotation default to false (Closed)

Created:
4 years, 9 months ago by perkj_webrtc
Modified:
4 years, 9 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, mflodman, sdk-team_agora.io
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Change VideoCapture_apply_rotation default to false BUG=webrtc:5621 R=pthatcher@webrtc.org Committed: https://crrev.com/6919457319b0088ed8b68db30f68a03966d67121 Cr-Commit-Position: refs/heads/master@{#12052}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fix old webrtc video capture test #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -19 lines) Patch
M webrtc/media/base/videobroadcaster_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/base/videocapturer.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/base/videocapturer_unittest.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M webrtc/media/base/videoframefactory.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/base/videosourceinterface.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_capture/test/video_capture_unittest.cc View 1 2 1 chunk +3 lines, -8 lines 0 comments Download
M webrtc/modules/video_capture/video_capture_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (12 generated)
perkj_webrtc
please?
4 years, 9 months ago (2016-03-10 21:35:13 UTC) #3
pthatcher1
lgtm
4 years, 9 months ago (2016-03-11 20:22:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1779883004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1779883004/20001
4 years, 9 months ago (2016-03-17 10:12:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 9 months ago (2016-03-17 12:12:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1779883004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1779883004/60001
4 years, 9 months ago (2016-03-17 12:43:35 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios64_sim_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_dbg/builds/6029) mac_gn_dbg on tryserver.webrtc (JOB_FAILED, ...
4 years, 9 months ago (2016-03-17 12:46:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1779883004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1779883004/80001
4 years, 9 months ago (2016-03-18 13:57:14 UTC) #17
perkj_webrtc
Committed patchset #4 (id:80001) manually as 6919457319b0088ed8b68db30f68a03966d67121 (presubmit successful).
4 years, 9 months ago (2016-03-18 15:57:04 UTC) #19
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/6919457319b0088ed8b68db30f68a03966d67121 Cr-Commit-Position: refs/heads/master@{#12052}
4 years, 9 months ago (2016-03-18 15:57:07 UTC) #21
perkj_webrtc
4 years, 9 months ago (2016-03-18 17:06:17 UTC) #22
Message was sent while issue was closed. 
A revert of this CL (patchset #4 id:80001) has been created in
https://codereview.webrtc.org/1807673008/ by perkj@webrtc.org.

The reason for reverting is: Seems to break on linux ubsan 

https://build.chromium.org/p/client.webrtc/builders/Linux%20UBSan/builds/247.

Powered by Google App Engine
This is Rietveld 408576698