Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1779773002: Make rtc::TimestampWrapAroundHandler handle backwards wrapping (Closed)

Created:
4 years, 9 months ago by sprang_webrtc
Modified:
4 years, 9 months ago
Reviewers:
pbos-webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make rtc::TimestampWrapAroundHandler handle backwards wrapping Also fix a timestamp issue in video analyzer test. BUG=webrtc:5637, webrtc:5537 Committed: https://crrev.com/1b3530b4df1dc5ef3a6c16b41d86dd910d24c573 Cr-Commit-Position: refs/heads/master@{#11938}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated tests, slightly changed limits #

Patch Set 3 : Added unit test for "no negative start" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -19 lines) Patch
M webrtc/base/timeutils.cc View 1 1 chunk +13 lines, -5 lines 0 comments Download
M webrtc/base/timeutils_unittest.cc View 1 2 1 chunk +41 lines, -11 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
sprang_webrtc
4 years, 9 months ago (2016-03-09 14:49:23 UTC) #2
mflodman
https://codereview.webrtc.org/1779773002/diff/1/webrtc/base/timeutils.cc File webrtc/base/timeutils.cc (right): https://codereview.webrtc.org/1779773002/diff/1/webrtc/base/timeutils.cc#newcode205 webrtc/base/timeutils.cc:205: return ts + ((num_wrap_ -1) << 32); Functionality LG, ...
4 years, 9 months ago (2016-03-09 15:01:57 UTC) #3
sprang_webrtc
https://codereview.webrtc.org/1779773002/diff/1/webrtc/base/timeutils.cc File webrtc/base/timeutils.cc (right): https://codereview.webrtc.org/1779773002/diff/1/webrtc/base/timeutils.cc#newcode205 webrtc/base/timeutils.cc:205: return ts + ((num_wrap_ -1) << 32); On 2016/03/09 ...
4 years, 9 months ago (2016-03-09 15:40:30 UTC) #4
mflodman
Thanks for the extra test! LGTM
4 years, 9 months ago (2016-03-09 16:29:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1779773002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1779773002/40001
4 years, 9 months ago (2016-03-09 16:29:47 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_baremetal on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_baremetal/builds/9587)
4 years, 9 months ago (2016-03-09 16:53:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1779773002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1779773002/40001
4 years, 9 months ago (2016-03-09 18:43:42 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_baremetal on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_baremetal/builds/9595)
4 years, 9 months ago (2016-03-09 19:10:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1779773002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1779773002/40001
4 years, 9 months ago (2016-03-10 08:35:25 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-10 09:32:58 UTC) #16
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 09:33:10 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1b3530b4df1dc5ef3a6c16b41d86dd910d24c573
Cr-Commit-Position: refs/heads/master@{#11938}

Powered by Google App Engine
This is Rietveld 408576698