Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: webrtc/api/videotrack_unittest.cc

Issue 1779063003: Refactor VideoTracks to forward all sinks to its source (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Removed unused code. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/videotrack_unittest.cc
diff --git a/webrtc/api/videotrack_unittest.cc b/webrtc/api/videotrack_unittest.cc
index 008ba2181fa33cf84c44c88bfb7c8e6572679bc7..4ca83d497c66c391f3ed6346cf1664aeffe9196e 100644
--- a/webrtc/api/videotrack_unittest.cc
+++ b/webrtc/api/videotrack_unittest.cc
@@ -65,6 +65,10 @@ TEST_F(VideoTrackTest, RenderVideo) {
capturer_.CaptureFrame();
EXPECT_EQ(2, renderer_1->num_rendered_frames());
EXPECT_EQ(2, renderer_2->num_rendered_frames());
+
+ // Need to re-add the FakeVideoTrackRenderer since its de-register itself in
pthatcher1 2016/03/11 20:20:17 its de-register => it deregisters
perkj_webrtc 2016/03/11 21:44:56 removed
+ // the dtor and we check if it exists in the source....
+ video_track_->AddOrUpdateSink(renderer_1.get(), rtc::VideoSinkWants());
}
// Test adding renderers to a video track and render to them by
@@ -90,6 +94,10 @@ TEST_F(VideoTrackTest, RenderVideoOld) {
capturer_.CaptureFrame();
EXPECT_EQ(2, renderer_1->num_rendered_frames());
EXPECT_EQ(2, renderer_2->num_rendered_frames());
+
+ // Need to re-add the FakeVideoTrackRenderer since its de-register itself in
+ // the dtor and we check if it exists in the source....
+ video_track_->AddOrUpdateSink(renderer_1.get(), rtc::VideoSinkWants());
}
// Test that disabling the track results in blacked out frames.

Powered by Google App Engine
This is Rietveld 408576698