Refactor AVAudioSession intialization code.

Refactor AVAudioSession intialization code.

BUG=

Committed: https://crrev.com/9f987d32008d989f719dffd032de55d46e7a0b4e
Cr-Commit-Position: refs/heads/master@{#11972}

[tkchin_webrtc, 2016-03-10 04:49:40]

Patchset #1 (id:1) has been deleted

[tkchin_webrtc, 2016-03-10 04:49:45]

Patchset #1 (id:20001) has been deleted

[tkchin_webrtc, 2016-03-10 04:49:59]

Description was changed from

==========
Refactor AVAudioSession intialization code.

BUG=
==========

to

==========
Refactor AVAudioSession intialization code.

BUG=
==========

[tkchin_webrtc, 2016-03-10 04:49:59]

tkchin@webrtc.org changed reviewers:
+ haysc@webrtc.org, henrika@webrtc.org

[tkchin_webrtc, 2016-03-10 04:51:04]

Part 2 of refactoring to prepare for new callbacks through the delegate.

[henrika_webrtc, 2016-03-10 14:42:12]

Looks like great work Zeke!

LGTM

https://codereview.webrtc.org/1778793005/diff/40001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/ios/objc/RTCAudioSession+Configuration.mm
(right):

https://codereview.webrtc.org/1778793005/diff/40001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/ios/objc/RTCAudioSession+Configuration.mm:56: //
Provide an error even if there isn't one so we can log it. We will not
Nit, you have space above comment on lines 25 and 26.

[Chuck, 2016-03-10 21:16:37]

Only a couple minor things, lgtm

https://codereview.webrtc.org/1778793005/diff/40001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/audio_device.gypi (right):

https://codereview.webrtc.org/1778793005/diff/40001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/audio_device.gypi:176:
'ios/objc/RTCAudioSession+Configuration.mm',
The other build file adds .h, this one adds .mm, is that correct?

https://codereview.webrtc.org/1778793005/diff/40001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/ios/objc/RTCAudioSession+Configuration.mm
(right):

https://codereview.webrtc.org/1778793005/diff/40001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/ios/objc/RTCAudioSession+Configuration.mm:61: error
= *outError;
I might be reasoning about this incorrectly, but will this actually return an
error object to the caller?

if (outError) {
  *outError = nil;
}

and

if (outError) {
  *outError = error;
}

at the end before return YES is what I would expect.

https://codereview.webrtc.org/1778793005/diff/40001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/ios/objc/RTCAudioSession+Configuration.mm:99: error
= nil;
This pattern is different than the other blocks of if() { error = nil;
Is that intentional?

https://codereview.webrtc.org/1778793005/diff/40001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/ios/objc/RTCAudioSessionConfiguration.h
(right):

https://codereview.webrtc.org/1778793005/diff/40001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/ios/objc/RTCAudioSessionConfiguration.h:25:
@property(nonatomic, strong) NSString *category;
Do you want to make the NSString * properties copy instead of strong? No strong
opinion either way.

[tkchin_webrtc, 2016-03-10 23:07:09]

PTAL

https://codereview.webrtc.org/1778793005/diff/40001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/audio_device.gypi (right):

https://codereview.webrtc.org/1778793005/diff/40001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/audio_device.gypi:176:
'ios/objc/RTCAudioSession+Configuration.mm',
On 2016/03/10 21:16:37, Chuck wrote:
> The other build file adds .h, this one adds .mm, is that correct?

Noooope!

Done.

https://codereview.webrtc.org/1778793005/diff/40001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/ios/objc/RTCAudioSession+Configuration.mm
(right):

https://codereview.webrtc.org/1778793005/diff/40001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/ios/objc/RTCAudioSession+Configuration.mm:56: //
Provide an error even if there isn't one so we can log it. We will not
On 2016/03/10 14:42:12, henrika_webrtc wrote:
> Nit, you have space above comment on lines 25 and 26.

Done.

https://codereview.webrtc.org/1778793005/diff/40001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/ios/objc/RTCAudioSession+Configuration.mm:61: error
= *outError;
On 2016/03/10 21:16:37, Chuck wrote:
> I might be reasoning about this incorrectly, but will this actually return an
> error object to the caller?
> 
> if (outError) {
>   *outError = nil;
> }
> 
> and
> 
> if (outError) {
>   *outError = error;
> }
> 
> at the end before return YES is what I would expect.

Done.

https://codereview.webrtc.org/1778793005/diff/40001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/ios/objc/RTCAudioSession+Configuration.mm:99: error
= nil;
On 2016/03/10 21:16:37, Chuck wrote:
> This pattern is different than the other blocks of if() { error = nil;
> Is that intentional?

Yup. Always forcing the active.

https://codereview.webrtc.org/1778793005/diff/40001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/ios/objc/RTCAudioSessionConfiguration.h
(right):

https://codereview.webrtc.org/1778793005/diff/40001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/ios/objc/RTCAudioSessionConfiguration.h:25:
@property(nonatomic, strong) NSString *category;
On 2016/03/10 21:16:37, Chuck wrote:
> Do you want to make the NSString * properties copy instead of strong? No
strong
> opinion either way.

Strong because we're pointing at system string constants.

[Chuck, 2016-03-11 15:29:23]

lgtm

[tkchin_webrtc, 2016-03-13 04:01:44]

The CQ bit was checked by tkchin@webrtc.org

[tkchin_webrtc, 2016-03-13 04:01:45]

The patchset sent to the CQ was uploaded after l-g-t-m from henrika@webrtc.org,
haysc@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1778793005/#ps100001 (title:
"Make isConfigured private")

[commit-bot: I haz the power, 2016-03-13 04:01:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1778793005/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1778793005/100001

[commit-bot: I haz the power, 2016-03-13 04:06:35]

Description was changed from

==========
Refactor AVAudioSession intialization code.

BUG=
==========

to

==========
Refactor AVAudioSession intialization code.

BUG=
==========

[commit-bot: I haz the power, 2016-03-13 04:06:36]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2016-03-13 04:06:39]

Description was changed from

==========
Refactor AVAudioSession intialization code.

BUG=
==========

to

==========
Refactor AVAudioSession intialization code.

BUG=

Committed: https://crrev.com/9f987d32008d989f719dffd032de55d46e7a0b4e
Cr-Commit-Position: refs/heads/master@{#11972}
==========

[commit-bot: I haz the power, 2016-03-13 04:06:40]

Patchset 4 (id:??) landed as
https://crrev.com/9f987d32008d989f719dffd032de55d46e7a0b4e
Cr-Commit-Position: refs/heads/master@{#11972}